summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Clay <matt@mystile.com>2020-06-17 18:22:41 +0200
committerMatt Clay <matt@mystile.com>2020-06-17 19:10:17 +0200
commit8152d8bc1a0981230d43b0e3e54085912193eb9b (patch)
tree008fc7685c6725958f0286131f93c6b407372b88
parentAdd an author exception for OpenStack Ansible SIG (diff)
downloadansible-8152d8bc1a0981230d43b0e3e54085912193eb9b.tar.xz
ansible-8152d8bc1a0981230d43b0e3e54085912193eb9b.zip
Disabled inconsistent pylint checks.stable-2.10-branchpoint
-rw-r--r--changelogs/fragments/ansible-test-sanity-pylint-config-fix.yml2
-rw-r--r--test/lib/ansible_test/_data/sanity/pylint/config/ansible-test.cfg2
-rw-r--r--test/lib/ansible_test/_data/sanity/pylint/config/collection.cfg2
-rw-r--r--test/lib/ansible_test/_data/sanity/pylint/config/default.cfg2
-rw-r--r--test/lib/ansible_test/_data/sanity/pylint/config/sanity.cfg2
5 files changed, 10 insertions, 0 deletions
diff --git a/changelogs/fragments/ansible-test-sanity-pylint-config-fix.yml b/changelogs/fragments/ansible-test-sanity-pylint-config-fix.yml
new file mode 100644
index 0000000000..5e863d0572
--- /dev/null
+++ b/changelogs/fragments/ansible-test-sanity-pylint-config-fix.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - ansible-test - Disabled the ``duplicate-code`` and ``cyclic-import`` checks for the ``pylint`` sanity test due to inconsistent results.
diff --git a/test/lib/ansible_test/_data/sanity/pylint/config/ansible-test.cfg b/test/lib/ansible_test/_data/sanity/pylint/config/ansible-test.cfg
index ea40c0bf55..d3643162c7 100644
--- a/test/lib/ansible_test/_data/sanity/pylint/config/ansible-test.cfg
+++ b/test/lib/ansible_test/_data/sanity/pylint/config/ansible-test.cfg
@@ -1,6 +1,8 @@
[MESSAGES CONTROL]
disable=
+ cyclic-import, # consistent results require running with --jobs 1 and testing all files
+ duplicate-code, # consistent results require running with --jobs 1 and testing all files
too-few-public-methods,
too-many-arguments,
too-many-branches,
diff --git a/test/lib/ansible_test/_data/sanity/pylint/config/collection.cfg b/test/lib/ansible_test/_data/sanity/pylint/config/collection.cfg
index c86765e3d0..c2d75b1c40 100644
--- a/test/lib/ansible_test/_data/sanity/pylint/config/collection.cfg
+++ b/test/lib/ansible_test/_data/sanity/pylint/config/collection.cfg
@@ -23,9 +23,11 @@ disable=
consider-using-in,
consider-using-set-comprehension,
consider-using-ternary,
+ cyclic-import, # consistent results require running with --jobs 1 and testing all files
deprecated-lambda,
deprecated-method,
deprecated-module,
+ duplicate-code, # consistent results require running with --jobs 1 and testing all files
eval-used,
exec-used,
expression-not-assigned,
diff --git a/test/lib/ansible_test/_data/sanity/pylint/config/default.cfg b/test/lib/ansible_test/_data/sanity/pylint/config/default.cfg
index b279926392..451990784e 100644
--- a/test/lib/ansible_test/_data/sanity/pylint/config/default.cfg
+++ b/test/lib/ansible_test/_data/sanity/pylint/config/default.cfg
@@ -23,9 +23,11 @@ disable=
consider-using-in,
consider-using-set-comprehension,
consider-using-ternary,
+ cyclic-import, # consistent results require running with --jobs 1 and testing all files
deprecated-lambda,
deprecated-method,
deprecated-module,
+ duplicate-code, # consistent results require running with --jobs 1 and testing all files
eval-used,
exec-used,
expression-not-assigned,
diff --git a/test/lib/ansible_test/_data/sanity/pylint/config/sanity.cfg b/test/lib/ansible_test/_data/sanity/pylint/config/sanity.cfg
index 7ecf0820ad..f601ab57d3 100644
--- a/test/lib/ansible_test/_data/sanity/pylint/config/sanity.cfg
+++ b/test/lib/ansible_test/_data/sanity/pylint/config/sanity.cfg
@@ -1,6 +1,8 @@
[MESSAGES CONTROL]
disable=
+ cyclic-import, # consistent results require running with --jobs 1 and testing all files
+ duplicate-code, # consistent results require running with --jobs 1 and testing all files
too-few-public-methods,
too-many-arguments,
too-many-branches,