summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexei Znamensky <103110+russoz@users.noreply.github.com>2024-11-07 15:56:51 +0100
committerGitHub <noreply@github.com>2024-11-07 15:56:51 +0100
commit1d61f2a4fdceac950a35583c446b6a0a7bf61f4a (patch)
tree697c7d845d6d422348f5698e21549aa84112d622
parentuser: create Buildroot subclass as alias to Busybox (#83666) (diff)
downloadansible-1d61f2a4fdceac950a35583c446b6a0a7bf61f4a.tar.xz
ansible-1d61f2a4fdceac950a35583c446b6a0a7bf61f4a.zip
remove ignore clauses for module uri (#83642)
Co-authored-by: flowerysong <junk+github@flowerysong.com>
-rw-r--r--changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml2
-rw-r--r--lib/ansible/modules/uri.py1
-rw-r--r--test/sanity/ignore.txt1
3 files changed, 3 insertions, 1 deletions
diff --git a/changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml b/changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml
new file mode 100644
index 0000000000..14ff7a0723
--- /dev/null
+++ b/changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - uri - mark ``url`` as required (https://github.com/ansible/ansible/pull/83642).
diff --git a/lib/ansible/modules/uri.py b/lib/ansible/modules/uri.py
index b19628b9aa..78e431f5df 100644
--- a/lib/ansible/modules/uri.py
+++ b/lib/ansible/modules/uri.py
@@ -605,6 +605,7 @@ def uri(module, url, dest, body, body_format, method, headers, socket_timeout, c
def main():
argument_spec = url_argument_spec()
+ argument_spec['url']['required'] = True
argument_spec.update(
dest=dict(type='path'),
url_username=dict(type='str', aliases=['user']),
diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt
index 5736094ef8..b3e8381137 100644
--- a/test/sanity/ignore.txt
+++ b/test/sanity/ignore.txt
@@ -25,7 +25,6 @@ lib/ansible/modules/service.py validate-modules:nonexistent-parameter-documented
lib/ansible/modules/service.py validate-modules:use-run-command-not-popen
lib/ansible/modules/stat.py validate-modules:parameter-invalid
lib/ansible/modules/systemd_service.py validate-modules:parameter-invalid
-lib/ansible/modules/uri.py validate-modules:doc-required-mismatch
lib/ansible/modules/user.py validate-modules:doc-default-does-not-match-spec
lib/ansible/modules/user.py validate-modules:use-run-command-not-popen
lib/ansible/module_utils/basic.py pylint:unused-import # deferring resolution to allow enabling the rule now