summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAbhijeet Kasurde <akasurde@redhat.com>2024-11-05 16:27:12 +0100
committerGitHub <noreply@github.com>2024-11-05 16:27:12 +0100
commita99d66e6c75fa9d54b6acfc0ff69039bfe6d428f (patch)
tree51844f903858d553739553926cf7a3f4e41e47e9
parentPython binary should not be python at first try for env-setup.fish (#84212) (diff)
downloadansible-a99d66e6c75fa9d54b6acfc0ff69039bfe6d428f.tar.xz
ansible-a99d66e6c75fa9d54b6acfc0ff69039bfe6d428f.zip
Removed deprecated STRING_CONVERSION_ACTION (#84245)
Fixes: #84220 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-rw-r--r--changelogs/fragments/string_conversion.yml3
-rw-r--r--lib/ansible/config/base.yml19
-rw-r--r--lib/ansible/module_utils/basic.py1
-rw-r--r--lib/ansible/module_utils/common/parameters.py1
-rw-r--r--lib/ansible/module_utils/csharp/Ansible.Basic.cs1
-rw-r--r--lib/ansible/plugins/action/__init__.py3
6 files changed, 3 insertions, 25 deletions
diff --git a/changelogs/fragments/string_conversion.yml b/changelogs/fragments/string_conversion.yml
new file mode 100644
index 0000000000..5803289617
--- /dev/null
+++ b/changelogs/fragments/string_conversion.yml
@@ -0,0 +1,3 @@
+---
+removed_features:
+ - Removed deprecated STRING_CONVERSION_ACTION (https://github.com/ansible/ansible/issues/84220).
diff --git a/lib/ansible/config/base.yml b/lib/ansible/config/base.yml
index 141f85caa4..f0d6f2b684 100644
--- a/lib/ansible/config/base.yml
+++ b/lib/ansible/config/base.yml
@@ -2039,25 +2039,6 @@ NETCONF_SSH_CONFIG:
- {key: ssh_config, section: netconf_connection}
yaml: {key: netconf_connection.ssh_config}
default: null
-STRING_CONVERSION_ACTION:
- version_added: '2.8'
- description:
- - Action to take when a module parameter value is converted to a string (this does not affect variables).
- For string parameters, values such as '1.00', "['a', 'b',]", and 'yes', 'y', etc.
- will be converted by the YAML parser unless fully quoted.
- - Valid options are 'error', 'warn', and 'ignore'.
- - Since 2.8, this option defaults to 'warn' but will change to 'error' in 2.12.
- default: 'warn'
- env:
- - name: ANSIBLE_STRING_CONVERSION_ACTION
- ini:
- - section: defaults
- key: string_conversion_action
- type: string
- deprecated:
- why: This option is no longer used in the Ansible Core code base.
- version: "2.19"
- alternatives: There is no alternative at the moment. A different mechanism would have to be implemented in the current code base.
VALIDATE_ACTION_GROUP_METADATA:
version_added: '2.12'
description:
diff --git a/lib/ansible/module_utils/basic.py b/lib/ansible/module_utils/basic.py
index 41ae6288c5..fbc5ea1763 100644
--- a/lib/ansible/module_utils/basic.py
+++ b/lib/ansible/module_utils/basic.py
@@ -394,7 +394,6 @@ class AnsibleModule(object):
# run_command invocation
self.run_command_environ_update = {}
self._clean = {}
- self._string_conversion_action = ''
self.aliases = {}
self._legal_inputs = []
diff --git a/lib/ansible/module_utils/common/parameters.py b/lib/ansible/module_utils/common/parameters.py
index b9f5be43a7..c80ca6ccf1 100644
--- a/lib/ansible/module_utils/common/parameters.py
+++ b/lib/ansible/module_utils/common/parameters.py
@@ -96,7 +96,6 @@ PASS_VARS = {
'selinux_special_fs': ('_selinux_special_fs', ['fuse', 'nfs', 'vboxsf', 'ramfs', '9p', 'vfat']),
'shell_executable': ('_shell', '/bin/sh'),
'socket': ('_socket_path', None),
- 'string_conversion_action': ('_string_conversion_action', 'warn'),
'syslog_facility': ('_syslog_facility', 'INFO'),
'tmpdir': ('_tmpdir', None),
'verbosity': ('_verbosity', 0),
diff --git a/lib/ansible/module_utils/csharp/Ansible.Basic.cs b/lib/ansible/module_utils/csharp/Ansible.Basic.cs
index 085958270d..1095042fe1 100644
--- a/lib/ansible/module_utils/csharp/Ansible.Basic.cs
+++ b/lib/ansible/module_utils/csharp/Ansible.Basic.cs
@@ -73,7 +73,6 @@ namespace Ansible.Basic
{ "selinux_special_fs", null },
{ "shell_executable", null },
{ "socket", null },
- { "string_conversion_action", null },
{ "syslog_facility", null },
{ "target_log_info", "TargetLogInfo"},
{ "tmpdir", "tmpdir" },
diff --git a/lib/ansible/plugins/action/__init__.py b/lib/ansible/plugins/action/__init__.py
index e0d500a8a8..370742487c 100644
--- a/lib/ansible/plugins/action/__init__.py
+++ b/lib/ansible/plugins/action/__init__.py
@@ -972,9 +972,6 @@ class ActionBase(ABC):
# let module know about filesystems that selinux treats specially
module_args['_ansible_selinux_special_fs'] = C.DEFAULT_SELINUX_SPECIAL_FS
- # what to do when parameter values are converted to strings
- module_args['_ansible_string_conversion_action'] = C.STRING_CONVERSION_ACTION
-
# give the module the socket for persistent connections
module_args['_ansible_socket'] = getattr(self._connection, 'socket_path')
if not module_args['_ansible_socket']: