summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update triple single quotes to triple double quotes (#84099)Matt Clay2024-10-09416-2236/+2236
| | | | | | | | | * Update triple single quotes to triple double quotes This change was fully automated. The updated Python files have been verified to tokenize the same as the originals, except for the expected change in quoting of strings, which were verified through literal_eval. * Manual conversion of docstring quotes
* ansible-test - Work around pylint issue on 3.11 (#84094)Matt Clay2024-10-092-4/+7
|
* ansible-test - Enable pylint docstyle for tests (#84092)Matt Clay2024-10-096-53/+50
| | | | | This cleans up the implementation of the pylint sanity test and enables the docstyle extension rule `bad-docstring-quotes` for tests. The rule will be enabled for the rest of ansible-core once automated cleanup has been performed on existing docstrings.
* ansible-test - Update base/default containers (#84089)Matt Clay2024-10-092-3/+4
|
* Fix copyright format for gather_facts and mount_facts as documented (#84087)Sloane Hertel2024-10-092-2/+2
|
* Cover unit tests with mypy (#84084)Matt Clay2024-10-0826-115/+218
| | | | | | | | | * Added support for testing unit tests with mypy. * Added support for ignoring individual mypy error codes. * Added missing assert on unit tests and marked xfail. * Added type hints for some unit tests. * Added ignores for unit tests not passing mypy. * Fixed incorrect autouse argument in unit test fixtures. * Fixed minor issues causing problems with mypy in unit tests.
* Update unique filter docs (#84078)Abhijeet Kasurde2024-10-081-3/+19
| | | | | | * Correct case_sensitive example * Add attribute docs Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* user module, avoid chmoding symlink'd home file (#83956)Brian Coca2024-10-084-2/+74
| | | | | | | also added tests --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* docs: `unique` add missing settings (#84076)Tinyblargon2024-10-081-0/+12
| | | add the `case_sensitive` setting
* PlayIterator: skip tasks from already ran roles (#83793)Martin Krizek2024-10-086-29/+23
| | | ... so strategies do not have to filter them.
* ansible-galaxy - fix ignoring certs when installing from git repos (#83332)Sloane Hertel2024-10-084-6/+49
| | | | | | | | | * Fix installing collections|roles from git repos with GALAXY_IGNORE_CERTS * Fix installing collections from git repos with --ignore-certs * Update unit test * Add test case
* ansible-test - Update astroid for pylint sanity test (#84054)Matt Clay2024-10-042-2/+2
|
* ansible-test - Disable pylint deprecated-* rules (#84050)Matt Clay2024-10-047-2/+21
|
* Implicit flush_handlers inherit play tags (#83968)Martin Krizek2024-10-045-12/+41
|
* Fix error message given by ansible.module_utils.facts.timeout.timeout (#83945)Sloane Hertel2024-10-033-4/+4
| | | | | * Update unit test Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
* ansible-test - Update sanity tests and default Python (#83998)Matt Clay2024-10-0313-23/+31
| | | | | * ansible-test - Update sanity test requirements * ansible-test - Default to Python 3.13 in base/default containers * ansible-test - Fix incorrect AnyStr type hints
* Reduce number of implicit meta tasks (#84007)Martin Krizek2024-10-0310-152/+93
| | | | | | | | | | | | | | | | | This greatly reduces run time on large inventories since meta tasks are executed in the main process sequentially and just executing them is expensive. This change avoids running the following implicit meta tasks: * ``flush_handlers`` on hosts where no handlers are notified * ``noop`` for the linear strategy's lockstep, instead hosts that are not executing the current task are just not part of the current host loop A playbook consiting of two simple plays both running on ~6000 hosts runs in: devel: 37s this PR: 1.3s Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
* file: simplify the code (#84043)Abhijeet Kasurde2024-10-032-94/+126
| | | | | | * Remove unnecessary code * Make code simple to read Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* get_url: properly parse filename in content-disposition (#83748)Martin Krizek2024-10-034-22/+41
| | | | | | | | | | Since we don't really care about the type we don't have to query for it and just retrieve the filename value. Unfortunately we cannot use module_utils.urls.get_response_filename as we don't have the response object, so just utilize email.message.Message to parse the filename instead of manually doing the work ourselves. Fixes: #83690
* Use sentinel everywhere (#84041)Abhijeet Kasurde2024-10-0319-94/+92
| | | | | * Use sentinel everywhere Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* ansible-test - Update nios-test-container to 6.0.0 (#84042)Matt Clay2024-10-022-1/+3
|
* remove one ignore clause for module copy (#83643)Alexei Znamensky2024-10-023-3/+4
| | | | --------- Co-authored-by: flowerysong <junk+github@flowerysong.com>
* cron: return stdout and rc for cron command (#83290)Jack Farzan2024-10-012-1/+4
| | | Co-authored-by: Jack Farzan <jfarzan@adobe.com>
* debconf: set empty password value (#83217)Abhijeet Kasurde2024-10-014-41/+153
| | | | | | Fixes: #83214 --------- Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Prevent condor from being installed and fulfilling libfmt dependency (#84023)Matt Martz2024-09-301-1/+1
|
* Add additional logging for SSH runtime output timeouts and escalation ↵uber-dendy2024-09-302-7/+12
| | | | | | | messages (#84008) Signed-off-by: Yuri Savinkin <stkwar@gmail.com> Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* INVENTORY_IGNORE_EXTS stop ignoring ini (#84001)Brian Coca2024-09-263-1/+5
| | | | | | | | | | | | * INVENTORY_IGNORE_EXTS stop ignoring ini Originally added to avoid configuration files for inventory scripts now clashes with the much more common ini inventory files. * add a note to script plugin * Update lib/ansible/plugins/inventory/script.py Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* facts: Skip path if the distribution path is directory (#84012)Abhijeet Kasurde2024-09-263-1/+21
| | | | | | | | | | | | | | | | * facts: Skip path if the distribution path is directory Skip path if the distribution path is directory instead of file. Handle exception raised while handling distribution path. Fixes: #84006 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Review requests --------- Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* package/dnf action plugins: better facts failure msg (#83995)Martin Krizek2024-09-263-9/+14
|
* Test entry points with editable install (#84002)Matt Clay2024-09-241-17/+32
| | | This allows collection of code coverage for the entry points.
* Ansible Errors, Don't hide stacked messages when yaml (#83933)Brian Coca2024-09-244-8/+16
| | | | | | Also remove redundant msg now that we fixed yaml case So no more need to %s % e. Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* split: Fix incorrect example result of the split builtin filter (#83982)林博仁 Buo-ren Lin2024-09-241-1/+1
| | | | | | | | | | | | The following Python output proves that the second member of the resulting list should be " a", not "a": ```txt $ python3 Python 3.12.3 (main, Sep 11 2024, 14:17:37) [GCC 13.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> string = "jojo is, a" >>> string.split(',') ['jojo is', ' a'] ```
* Add basic validation for action_groups (#83965)Felix Fontein2024-09-246-1/+60
| | | Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* dnf5: fix tb when plugins API is not available (#83969)Martin Krizek2024-09-242-1/+11
| | | Follow up on https://github.com/ansible/ansible/pull/83105
* Move ansible-deprecated ignores for tests inline (#83989)Matt Clay2024-09-243-17/+13
|
* zap changelogs (#83988)Matt Davis2024-09-24157-446/+1
|
* bump devel to 2.19 (#83985)Matt Davis2024-09-243-2/+10
|
* isidentifier: Remove Python 2 specific code (#83688)Abhijeet Kasurde2024-09-233-34/+20
| | | Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* ansible-test - Use Python version in pylint contexts (#83984)Matt Clay2024-09-233-43/+25
|
* ansible-galaxy - fix the usage for role/collection install (#83979)Sloane Hertel2024-09-231-1/+1
|
* dnf5: re-introduce ``state: installed`` alias (#83961)Martin Krizek2024-09-233-3/+5
| | | Fixes #83960
* Do not convert floats to ints when there is truncation (#83864)Brian Coca2024-09-209-110/+43
| | | | | | | Adjusted error messages fixed tests removed py2 compat tests, since no more py2 Co-authored-by: Matt Clay <matt@mystile.com>
* Add mount_facts module (#83508)Sloane Hertel2024-09-197-0/+1847
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add a mount_facts module capable of gathering mounts skipped by default fact gathering * By default, collect mount facts from standard locations including /etc/mtab, /proc/mounts, /etc/fstab, /etc/mnttab, /etc/vfstab, and on AIX, /etc/filesystems. When no file-based source for the current mounts can be found (like /proc/mounts), the module falls back to using mount as a source. This allows BSD and AIX to collect the existing mounts by default, without causing Linux hosts to use both /proc/mounts and mount output. * Non-standard locations and "mount" can be configured as a sources. * Support returning an aggregate list of mount points in addition to first found. When there are multiple mounts for the same mount point in an individual source, a warning is given if the include_aggregate_mounts option is not configured. * Add options to filter on fstypes and devices (supporting UNIX shell wildcards). * Support configuring a timeout and timeout behavior to make it easier to use the module as a default facts module without risking a hang. * Include the source and line(s) corresponding to a mount for easier debugging. Co-authored-by: Brian Coca <bcoca@users.noreply.github.com> Co-authored-by: Matt Clay <matt@mystile.com> Co-authored-by: Matt Davis <6775756+nitzmahone@users.noreply.github.com>
* ansible-test no longer needs special casing in `__main__.py` (#83962)Matt Martz2024-09-191-17/+2
|
* Clarify galaxy CLI --help about install locations (#83919)Sloane Hertel2024-09-182-4/+32
| | | | | | | | | | * add descriptions for `ansible-galaxy install` and `ansible-galaxy role|collection install` * fix the usage for installing roles and collections together and include collections in the description for -r Closes #81159 Co-authored-by: Alan Rominger <arominge@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com>
* timedout extended (#83953)Brian Coca2024-09-185-1/+46
| | | | | * timedout extended * add timedout test
* Update communication links for the forum (#83862)Don Naro2024-09-166-42/+60
| | | | | | | | | | | * update communication details in README * update comms details in contributing * update comms details in issue templates * add link to contributors guide * point to devel for comms
* runas - create new SYTEM token for become (#83827)Jordan Borean2024-09-132-25/+18
| | | | | | | | | | Instead of re-using the token used in impersonation, this change will create a new token for the SYSTEM account as returned by LogonUser. The benefits of this is that the token will contain the full privileges for the SYSTEM account rather than potentially one that has restricted privileges we used during impersonation. It should also help avoid problems on Windows that fails on status 0x0000016F when the impersonated token during become was from a process that is restricted from creating sub processes.
* file module: Clarify the docs that the force parameter works for hardlinks ↵Gleb Popov2024-09-111-2/+2
| | | | too (#83913)
* service_facts, fix systemd/ubuntu failed reporting (#83424)Brian Coca2024-09-102-4/+8
| | | Avoid check description, better comments
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 22:39:39 +0100