1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
|
#!/usr/bin/env python
# PYTHON_ARGCOMPLETE_OK
"""Create GitHub issues for deprecated features."""
from __future__ import annotations
import abc
import argparse
import dataclasses
import os
import pathlib
import re
import subprocess
import sys
import typing as t
import yaml
try:
# noinspection PyPackageRequirements
import argcomplete
except ImportError:
argcomplete = None
from ansible.release import __version__
MAJOR_MINOR_VERSION = '.'.join(__version__.split('.')[:2])
PROJECT = f'ansible-core {MAJOR_MINOR_VERSION}'
@dataclasses.dataclass(frozen=True)
class Issue:
title: str
summary: str
body: str
project: str
labels: list[str] | None = None
assignee: str | None = None
def create(self) -> str:
cmd = ['gh', 'issue', 'create', '--title', self.title, '--body', self.body, '--project', self.project]
if self.labels:
for label in self.labels:
cmd.extend(('--label', label))
if self.assignee:
cmd.extend(('--assignee', self.assignee))
try:
process = subprocess.run(cmd, capture_output=True, check=True, text=True)
except subprocess.CalledProcessError as ex:
print('>>> Note')
print(f"You may need to run 'gh auth refresh -s project' if 'gh' reports it cannot find the project {self.project!r} when it exists.")
print(f'>>> Standard Output\n{ex.stdout.strip()}\n>>> Standard Error\n{ex.stderr.strip()}\n>>> Exception')
raise
url = process.stdout.strip()
return url
@dataclasses.dataclass(frozen=True)
class Feature:
title: str
summary: str
component: str
labels: list[str] | None = None
assignee: str | None = None
@staticmethod
def from_dict(data: dict[str, t.Any]) -> Feature:
title = data.get('title')
summary = data.get('summary')
component = data.get('component')
labels = data.get('labels')
assignee = data.get('assignee')
if not isinstance(title, str):
raise RuntimeError(f'`title` is not `str`: {title}')
if not isinstance(summary, str):
raise RuntimeError(f'`summary` is not `str`: {summary}')
if not isinstance(component, str):
raise RuntimeError(f'`component` is not `str`: {component}')
if not isinstance(assignee, (str, type(None))):
raise RuntimeError(f'`assignee` is not `str`: {assignee}')
if not isinstance(labels, list) or not all(isinstance(item, str) for item in labels):
raise RuntimeError(f'`labels` is not `list[str]`: {labels}')
return Feature(
title=title,
summary=summary,
component=component,
labels=labels,
assignee=assignee,
)
def create_issue(self, project: str) -> Issue:
body = f'''
### Summary
{self.summary}
### Issue Type
Feature Idea
### Component Name
`{self.component}`
'''
return Issue(
title=self.title,
summary=self.summary,
body=body.strip(),
project=project,
labels=self.labels,
assignee=self.assignee,
)
@dataclasses.dataclass(frozen=True)
class BugReport:
title: str
summary: str
component: str
labels: list[str] | None = None
def create_issue(self, project: str) -> Issue:
body = f'''
### Summary
{self.summary}
### Issue Type
Bug Report
### Component Name
`{self.component}`
### Ansible Version
{MAJOR_MINOR_VERSION}
### Configuration
N/A
### OS / Environment
N/A
### Steps to Reproduce
N/A
### Expected Results
N/A
### Actual Results
N/A
'''
return Issue(
title=self.title,
summary=self.summary,
body=body.strip(),
project=project,
labels=self.labels,
)
@dataclasses.dataclass(frozen=True)
class Deprecation(metaclass=abc.ABCMeta):
@staticmethod
@abc.abstractmethod
def parse(message: str) -> Deprecation:
pass
@abc.abstractmethod
def create_bug_report(self) -> BugReport:
pass
@dataclasses.dataclass(frozen=True)
class DeprecatedConfig(Deprecation):
path: str
config: str
version: str
@staticmethod
def parse(message: str) -> DeprecatedConfig:
match = re.search('^(?P<path>.*):[0-9]+:[0-9]+: (?P<config>.*) is scheduled for removal in (?P<version>[0-9.]+)$', message)
if not match:
raise Exception(f'Unable to parse: {message}')
return DeprecatedConfig(
path=match.group('path'),
config=match.group('config'),
version=match.group('version'),
)
def create_bug_report(self) -> BugReport:
return BugReport(
title=f'Remove deprecated {self.config}',
summary=f'The config option `{self.config}` should be removed from `{self.path}`. It was scheduled for removal in {self.version}.',
component=self.path,
)
@dataclasses.dataclass(frozen=True)
class UpdateBundled(Deprecation):
path: str
package: str
old_version: str
new_version: str
json_link: str
link: str = dataclasses.field(default='', init=False)
def __post_init__(self) -> None:
object.__setattr__(self, 'link', re.sub('/json$', '', self.json_link))
@staticmethod
def parse(message: str) -> UpdateBundled:
match = re.search('^(?P<path>.*):[0-9]+:[0-9]+: UPDATE (?P<package>.*) from (?P<old>[0-9.]+) to (?P<new>[0-9.]+) (?P<link>https://.*)$', message)
if not match:
raise Exception(f'Unable to parse: {message}')
return UpdateBundled(
path=match.group('path'),
package=match.group('package'),
old_version=match.group('old'),
new_version=match.group('new'),
json_link=match.group('link'),
)
def create_bug_report(self) -> BugReport:
return BugReport(
title=f'Update bundled {self.package} to {self.new_version}',
summary=f'Update the bundled package [{self.package}]({self.link}) from `{self.old_version}` to `{self.new_version}`.',
component=self.path,
)
TEST_OPTIONS = {
'update-bundled': UpdateBundled,
'deprecated-config': DeprecatedConfig,
}
@dataclasses.dataclass(frozen=True)
class Args:
create: bool
verbose: bool
def run(self) -> None:
raise NotImplementedError()
@dataclasses.dataclass(frozen=True)
class DeprecationArgs(Args):
tests: list[str]
def run(self) -> None:
deprecated_command(self)
@dataclasses.dataclass(frozen=True)
class FeatureArgs(Args):
source: pathlib.Path
def run(self) -> None:
feature_command(self)
def parse_args() -> Args:
parser = argparse.ArgumentParser()
create_common_arguments(parser)
subparser = parser.add_subparsers(required=True)
create_deprecation_parser(subparser)
create_feature_parser(subparser)
args = invoke_parser(parser)
return args
def create_deprecation_parser(subparser) -> None:
parser: argparse.ArgumentParser = subparser.add_parser('deprecation')
parser.set_defaults(type=DeprecationArgs)
parser.set_defaults(command=deprecated_command)
parser.add_argument(
'--test',
dest='tests',
choices=tuple(TEST_OPTIONS),
action='append',
help='sanity test name',
)
create_common_arguments(parser)
def create_feature_parser(subparser) -> None:
epilog = """
Example source YAML:
default:
component: ansible-test
labels:
- ansible-test
- feature
assignee: "@me"
features:
- title: Some title goes here
summary: A summary goes here.
"""
parser: argparse.ArgumentParser = subparser.add_parser('feature', epilog=epilog, formatter_class=argparse.RawDescriptionHelpFormatter)
parser.set_defaults(type=FeatureArgs)
parser.set_defaults(command=feature_command)
parser.add_argument(
'--source',
type=pathlib.Path,
default=pathlib.Path('issues.yml'),
help='YAML file containing issue details (default: %(default)s)',
)
create_common_arguments(parser)
def create_common_arguments(parser: argparse.ArgumentParser) -> None:
parser.add_argument(
'--create',
action='store_true',
help='create issues on GitHub',
)
parser.add_argument(
'-v',
dest='verbose',
action='store_true',
help='verbose output',
)
def invoke_parser(parser: argparse.ArgumentParser) -> Args:
if argcomplete:
argcomplete.autocomplete(parser)
parsed_args = parser.parse_args()
kvp = {}
args_type = parsed_args.type
for field in dataclasses.fields(args_type):
kvp[field.name] = getattr(parsed_args, field.name)
args = args_type(**kvp)
return args
def run_sanity_test(test_name: str) -> list[str]:
cmd = ['ansible-test', 'sanity', '--test', test_name, '--lint', '--failure-ok']
skip_path = 'test/sanity/code-smell/skip.txt'
skip_temp_path = skip_path + '.tmp'
os.rename(skip_path, skip_temp_path) # make sure ansible-test isn't configured to skip any tests
try:
process = subprocess.run(cmd, capture_output=True, check=True)
finally:
os.rename(skip_temp_path, skip_path) # restore the skip entries
messages = process.stdout.decode().splitlines()
return messages
def create_issues_from_deprecation_messages(test_type: t.Type[Deprecation], messages: list[str]) -> list[Issue]:
deprecations = [test_type.parse(message) for message in messages]
bug_reports = [deprecation.create_bug_report() for deprecation in deprecations]
issues = [bug_report.create_issue(PROJECT) for bug_report in bug_reports]
return issues
def info(message: str) -> None:
print(message, file=sys.stderr)
def main() -> None:
args = parse_args()
args.run()
def deprecated_command(args: DeprecationArgs) -> None:
issues: list[Issue] = []
for test in args.tests or list(TEST_OPTIONS):
test_type = TEST_OPTIONS[test]
info(f'Running "{test}" sanity test...')
messages = run_sanity_test(test)
issues.extend(create_issues_from_deprecation_messages(test_type, messages))
create_issues(args, issues)
def feature_command(args: FeatureArgs) -> None:
with args.source.open() as source_file:
source = yaml.safe_load(source_file)
default: dict[str, t.Any] = source.get('default', {})
features: list[dict[str, t.Any]] = source.get('features', [])
if not isinstance(default, dict):
raise RuntimeError('`default` must be `dict[str, ...]`')
if not isinstance(features, list):
raise RuntimeError('`features` must be `list[dict[str, ...]]`')
issues: list[Issue] = []
for feature in features:
data = default.copy()
data.update(feature)
feature = Feature.from_dict(data)
issues.append(feature.create_issue(PROJECT))
create_issues(args, issues)
def create_issues(args: Args, issues: list[Issue]) -> None:
if not issues:
info('No issues found.')
return
info(f'Found {len(issues)} issue(s) to report:')
for issue in issues:
info(f'[{issue.title}] {issue.summary}')
if args.verbose:
info('>>>')
info(issue.body)
info('>>>')
if args.create:
url = issue.create()
info(url)
if not args.create:
info('Pass the "--create" option to create these issues on GitHub.')
if __name__ == '__main__':
main()
|