summaryrefslogtreecommitdiffstats
path: root/modules/proxy/mod_proxy_balancer.c
diff options
context:
space:
mode:
authorJean-Frederic Clere <jfclere@apache.org>2018-11-23 10:32:20 +0100
committerJean-Frederic Clere <jfclere@apache.org>2018-11-23 10:32:20 +0100
commite4b68ca5fc288e277c460dcf37585685bf6b3d8b (patch)
tree6422ce6daab48ba21c8a8a1b425ae4dc59e0b0d7 /modules/proxy/mod_proxy_balancer.c
parent* modules/dav/main/mod_dav.c (dav_method_propfind): Tag the scratchpool. (diff)
downloadapache2-e4b68ca5fc288e277c460dcf37585685bf6b3d8b.tar.xz
apache2-e4b68ca5fc288e277c460dcf37585685bf6b3d8b.zip
Add error messages and return bad request.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1847232 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to '')
-rw-r--r--modules/proxy/mod_proxy_balancer.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/modules/proxy/mod_proxy_balancer.c b/modules/proxy/mod_proxy_balancer.c
index ad8d3c3e24..80e64944e8 100644
--- a/modules/proxy/mod_proxy_balancer.c
+++ b/modules/proxy/mod_proxy_balancer.c
@@ -1411,12 +1411,23 @@ static int balancer_handler(request_rec *r)
bsel->wupdated = bsel->s->wupdated = nworker->s->updated = apr_time_now();
/* by default, all new workers are disabled */
ap_proxy_set_wstatus(PROXY_WORKER_DISABLED_FLAG, 1, nworker);
+ } else {
+ ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(01207)
+ "%s: failed to add worker %s",
+ bsel->s->name, val);
+ PROXY_GLOBAL_UNLOCK(bsel);
+ return HTTP_BAD_REQUEST;
}
if ((rv = PROXY_GLOBAL_UNLOCK(bsel)) != APR_SUCCESS) {
ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(01203)
"%s: Unlock failed for adding worker",
bsel->s->name);
}
+ } else {
+ ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(01207)
+ "%s: failed to add worker %s",
+ bsel->s->name, val);
+ return HTTP_BAD_REQUEST;
}
}