summaryrefslogtreecommitdiffstats
path: root/modules/metadata/mod_usertrack.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Slighly simplify code.Christophe Jaillet2020-02-281-12/+4
| | | | | | | | | No need to set to NULL or 0 fields that are apr_pcalloc'ed. Axe 'set_cookie_enable' and use 'ap_set_flag_slot' instead. (based on ideas taken from r1874389) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874602 13f79535-47bb-0310-9956-ffa450edef68
* Remove duplicated "CookieTracking" directive in 'command_rec'.Christophe Jaillet2020-02-281-2/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874601 13f79535-47bb-0310-9956-ffa450edef68
* * Another whitespace fixRuediger Pluem2020-02-251-1/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874481 13f79535-47bb-0310-9956-ffa450edef68
* * Whitespace fixRuediger Pluem2020-02-251-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874480 13f79535-47bb-0310-9956-ffa450edef68
* PR64077: samesite/httponly/secure flags for usertrackEric Covener2020-02-221-0/+55
| | | | | | | | | Submitted By: Prashant Keshvani <prashant2400 gmail.com>, Eric Covener Committed By: covener git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874389 13f79535-47bb-0310-9956-ffa450edef68
* Remove some useless 'return' statements.Christophe Jaillet2015-11-211-1/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1715571 13f79535-47bb-0310-9956-ffa450edef68
* Save a few bytes of memory. This can be done in temp_pool.Christophe Jaillet2014-05-231-4/+4
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1597182 13f79535-47bb-0310-9956-ffa450edef68
* Various code cleanup to avoid compiler, cppcheck, or clang warnings:Stefan Fritsch2011-12-181-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | modules/debugging/mod_firehose.c: Make some internal functions static (to do: logs_cleanup() is unused) modules/filters/mod_charset_lite.c: Remove dead assignments modules/filters/mod_include.c: likewise modules/metadata/mod_usertrack.c: likewise modules/proxy/mod_proxy_ftp.c: likewise modules/ssl/ssl_engine_pphrase.c: likewise modules/proxy/mod_proxy_balancer.c: likewise; Remove NULL check that can never happen modules/proxy/proxy_util.c: Axe NULL-check that can never happen and if it would, it would just mask another bug os/unix/unixd.c: likewise modules/http/http_filters.c: Remove sub-condition that is always true modules/lua/mod_lua.c: Add default cases to switch statements modules/generators/mod_autoindex.c: Unsigned value can never be < 0 server/util_expr_eval.c: Fix compiler warnings with VC and on OS2 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1220493 13f79535-47bb-0310-9956-ffa450edef68
* Add lots of unique tags to error log messagesStefan Fritsch2011-12-031-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1209766 13f79535-47bb-0310-9956-ffa450edef68
* Use random value instead of remote IP address in cookie value. This has theStefan Fritsch2011-11-091-9/+6
| | | | | | | | advantage that we don't leak internal IP addresses in reverse proxy setups. Also, use hex to make the cookie shorter. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1199987 13f79535-47bb-0310-9956-ffa450edef68
* More checks of ap_pregsub return valuesStefan Fritsch2011-11-071-0/+11
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1198959 13f79535-47bb-0310-9956-ffa450edef68
* PR29755: mod_usertrack gets skipped when modules return a status code fromEric Covener2011-08-071-2/+2
| | | | | | | | | | | their fixup hook, and headers are also not sent on non-2xx responses. Submitted by: Sami J. Mäkinen Reviewed by: Eric Covener (modified to just run REALLY_FIRST) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1154620 13f79535-47bb-0310-9956-ffa450edef68
* more temp pool usage and remove some useless apr_pstrdup()sStefan Fritsch2010-10-231-4/+4
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1026660 13f79535-47bb-0310-9956-ffa450edef68
* remove some useless use of strlen()Stefan Fritsch2010-08-031-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@982017 13f79535-47bb-0310-9956-ffa450edef68
* Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to takeStefan Fritsch2010-06-061-1/+1
| | | | | | | advantage of per-module loglevels git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@951895 13f79535-47bb-0310-9956-ffa450edef68
* update license header textRoy T. Fielding2006-07-111-6/+6
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@420983 13f79535-47bb-0310-9956-ffa450edef68
* Update the copyright year in all .c, .h and .xml filesColm MacCarthaigh2006-04-191-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@395228 13f79535-47bb-0310-9956-ffa450edef68
* No functional change: remove "internal" tab spacing/formatting.Jim Jagielski2005-11-161-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@345053 13f79535-47bb-0310-9956-ffa450edef68
* No functional Change: Removing trailing whitespace. This alsoJim Jagielski2005-11-101-3/+3
| | | | | | | | means that "blank" lines consisting of just spaces or tabs are now really blank lines git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@332306 13f79535-47bb-0310-9956-ffa450edef68
* No functional change: simple detabbing of indented code.Jim Jagielski2005-11-101-5/+5
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@332305 13f79535-47bb-0310-9956-ffa450edef68
* Move the POSIX reg* implementations into the ap_* namespace;Joe Orton2005-02-111-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | internalise the ap_reg*<->PCRE wrapper: * configure.in: Add srclib/pcre to the include path. * include/ap_regex.h: Renamed from include/pcreposix.h. Prefix all constants with AP_; prefix all functions and types with ap_. Define AP_DECLARE to nothing if necessary. Remove regcomp error codes. * include/httpd.h: Include ap_regex.h not pcreposix.h. (ap_pregcomp, ap_regexec, ap_regfree): s/regex_t/ap_regex_t/. (ap_regexec, ap_regerror): Prototypes moved to ap_regex.h. * server/util.c (regex_cleanup, ap_pregcomp, ap_pregsub, ap_pregfree): Adjust for ap_ prefixed types. (ap_regexec, ap_regerror): Removed. * server/Makefile.in: Build util_pcre.c. * server/util_pcre.c: Copied from srclib/pcre/pcreposix.c; remove use of PCRE-internals to do error mapping; rename types to add AP_/ap_ prefixes as above. Use APR includes. (ap_regerror): Use apr_snprintf. * srclib/pcre/Makefile.in: Don't build pcreposix.c into libpcre.la. * modules/*: Update to use new type and constant names. PR: 27750 (part one) Submitted by: Andres Salomon <dilinger voxel.net>, Joe Orton git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@153384 13f79535-47bb-0310-9956-ffa450edef68
* Update copyright year to 2005 and standardize on current copyright owner line.Justin Erenkrantz2005-02-041-1/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@151408 13f79535-47bb-0310-9956-ffa450edef68
* Just a simple switch of mod_usertrack to run earlier in the fixup hook.Paul Querna2004-11-041-1/+1
| | | | | | | PR: 29755 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105677 13f79535-47bb-0310-9956-ffa450edef68
* Fix a bunch of cases where the return code of the regex compilerAndré Malo2004-04-101-0/+1
| | | | | | | | | | was not checked properly. This affects: mod_setenvif, mod_usertrack, mod_proxy, mod_proxy_ftp and core. PR: 28218 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@103328 13f79535-47bb-0310-9956-ffa450edef68
* escape the cookie_name before pasting into the regexp.André Malo2004-04-101-1/+33
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@103326 13f79535-47bb-0310-9956-ffa450edef68
* let's be more lenient, in what we accept.André Malo2004-04-101-2/+2
| | | | | | | commas are allowed as separators and whitespaces are not a must. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@103325 13f79535-47bb-0310-9956-ffa450edef68
* Fix bug in mod_usertrack when no CookieName is set.Justin Erenkrantz2004-03-091-10/+21
| | | | | | | | | PR: 24483 Submitted by: Manni Wood <manniwood planet-save.com> Reviewed by: Cliff Woolley, Jim Jagielski git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102890 13f79535-47bb-0310-9956-ffa450edef68
* fix name of The Apache Software FoundationAndré Malo2004-02-091-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102618 13f79535-47bb-0310-9956-ffa450edef68
* fix copyright dates according to the first check inAndré Malo2004-02-081-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102572 13f79535-47bb-0310-9956-ffa450edef68
* apply Apache License, Version 2.0André Malo2004-02-061-53/+10
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102525 13f79535-47bb-0310-9956-ffa450edef68
* according to RFC 2965, inspect only the Cookie header (vs. Cookie2)André Malo2004-01-131-4/+1
| | | | | | | | PR: 11475 Submitted by: chrisd pearsoncmg.com (Chris Darroch) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102311 13f79535-47bb-0310-9956-ffa450edef68
* don't overwrite other cookiesAndré Malo2004-01-131-1/+1
| | | | | | | | PR: 26002 Submitted by: apache nopdesign.com (Scott Moore) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102309 13f79535-47bb-0310-9956-ffa450edef68
* update license to 2004.André Malo2004-01-011-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102135 13f79535-47bb-0310-9956-ffa450edef68
* The problem that this patch solves is one where cookie names are mis-identifiedCliff Woolley2003-09-241-16/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | by mod_usertrack. This is because of the use of strstr() in spot_cookie() the original mod_usertrack.c to find the name of the cookie. strstr(), by virtue of looking for a substring instead of an exact match, can mis-identify the cookie "MyID" as the cookie "ID" or "My". So, if you were looking for the value of the cookie "ID", but only the cookie "MyID" was returned by the browser, mod_usertrack.c would return the value of the "MyID" cookie in place of the "ID" you were looking for. Even more seriously, because strstr is invoked before the cookie name is separated from its cookie value, a cookie and value like "myCookie=thisisnotIDeal" will be a false positive if you told mod_usertrack the cookie name was ID. Furthermore, using this example, "eal" will get logged as the value of the cookie; now that strstr has incorrectly identified the substring "ID" as the cookie name, the following "e" (assumed to be the "=" sign) gets discarded, and the remaining content used as the value of the cookie. Replacing the strstr() with a more robust regex match fixes this problem. PR: 16661 Submitted by: Manni Wood <manniwood@planet-save.com> git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@101306 13f79535-47bb-0310-9956-ffa450edef68
* mod_usertrack: don't set the cookie in subrequests. This worksAndré Malo2003-03-071-1/+2
| | | | | | | | | | around the problem that cookies were set twice during fast internal redirects. PR: 13211 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@98910 13f79535-47bb-0310-9956-ffa450edef68
* finished that boring job:André Malo2003-02-031-1/+1
| | | | | | | | | update license to 2003. Happy New Year! ;-)) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@98573 13f79535-47bb-0310-9956-ffa450edef68
* use APR_TIME_T_FMT when formatting apr_time_tJeff Trawick2002-07-171-1/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@96099 13f79535-47bb-0310-9956-ffa450edef68
* Replaced APR_USEC_PER_SEC division with the new apr_time_sec() macroBrian Pane2002-06-301-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95916 13f79535-47bb-0310-9956-ffa450edef68
* Update callers of apr_explode_gmt to apr_time_exp_gmt. TheSander Striker2002-03-211-2/+2
| | | | | | | | | function was renamed in apr. Submitted by: Thom May <thom@planetarytramp.net> git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@94081 13f79535-47bb-0310-9956-ffa450edef68
* Update our copyright for this year.Roy T. Fielding2002-03-131-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93918 13f79535-47bb-0310-9956-ffa450edef68
* apr-utils rename apr_ansi_time_to_apr_time andIan Holsman2002-03-061-1/+1
| | | | | | | | | | | | apr_exploded_time_t. PR: Obtained from: Submitted by: Thom May <thom@planetarytramp.net> Reviewed by: Ian Holsman git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93733 13f79535-47bb-0310-9956-ffa450edef68
* Kill off some expensive, unnecessary effort when we use max-age forWilliam A. Rowe Jr2001-10-011-11/+5
| | | | | | | the usertrack cookie (and kill a warning in the process.) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91215 13f79535-47bb-0310-9956-ffa450edef68
* From Mark Cox:Jeff Trawick2001-08-291-13/+6
| | | | | | | | | | | I've had a couple of emails from users using mod_usertrack for authentication. Add the equivalent of a "warning: coffee may be hot" label, and fix a broken email address at the same time. Submitted by: Mark Cox git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90780 13f79535-47bb-0310-9956-ffa450edef68
* can't pass const char * to ap_strchr()Jeff Trawick2001-08-161-1/+1
| | | | | | | | (note that when AP_DEBUG is on, strchr() maps to ap_strchr() so we find abuses of the broken strchr() interface) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90211 13f79535-47bb-0310-9956-ffa450edef68
* Add CookieDomain directive to allow setting of the Domain=Ken Coar2001-08-161-16/+120
| | | | | | | | | | | | | cookie attribute; add CookieStyle to allow specification of cookie syntax: Netscape (default), Cookie or RFC2109, or Cookie2 or RFC2965. We have historically supported only the obsolete Netscape syntax. PR: several against 1.3 Obtained from: brought forward from 1.3 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90180 13f79535-47bb-0310-9956-ffa450edef68
* tweak ap_get_remote_host() so that the caller can find out if she gotJeff Trawick2001-03-091-1/+1
| | | | | | | | | back an IP address mod_access needed to know this, but the old code didn't handle IPv6 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88484 13f79535-47bb-0310-9956-ffa450edef68
* Update copyright to 2001Roy T. Fielding2001-02-161-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88184 13f79535-47bb-0310-9956-ffa450edef68
* Fix more module breakage from header reorgWilliam A. Rowe Jr2001-02-101-0/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88069 13f79535-47bb-0310-9956-ffa450edef68
* *) continued header revampingGreg Stein2001-02-101-4/+6
| | | | | | | *) torch some headers (and some libs) from the autoconf stuff git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88061 13f79535-47bb-0310-9956-ffa450edef68
* renaming various functions for consistency sakeDoug MacEachern2001-02-081-1/+1
| | | | | | | | | | | see: http://apr.apache.org/~dougm/apr_rename.pl PR: Obtained from: Submitted by: Reviewed by: git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88019 13f79535-47bb-0310-9956-ffa450edef68