summaryrefslogtreecommitdiffstats
path: root/server (follow)
Commit message (Collapse)AuthorAgeFilesLines
* event: avoid possible hang in clean_child_exitEric Covener2024-03-111-0/+1
| | | | | | | | | | | | | If the pthread_create failure isn't on the first worker thread, another one is likely to hold the queue mutex already. The cleanup of pchild will try to cleanup the queue and block on destroying the condition. ST_UNGRACEFUL as we have no listener thread yet. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1916241 13f79535-47bb-0310-9956-ffa450edef68
* * server/util_expr_parse.c (yyparse): Fix typo in comment.Joe Orton2024-02-021-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1915543 13f79535-47bb-0310-9956-ffa450edef68
* Updated typo NWGNUmakefileRich Bowen2024-01-241-1/+1
| | | | | | | | | | | dependencies was spelled dependancies. Submitted by: StevenSedwick <133059415+StevenSedwick@users.noreply.github.com> Github: closes #382 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1915380 13f79535-47bb-0310-9956-ffa450edef68
* regex: Add AP_REG_NOTEMPTY_ATSTART maching option.Yann Ylavic2024-01-161-0/+2
| | | | | | | | | | | | | | | * include/ap_mmn.h: Bump MMN minor. * include/ap_regex.h: Define AP_REG_NOTEMPTY_ATSTART bit. * server/util_pcre.c(ap_regexec_ex): Map AP_REG_NOTEMPTY_ATSTART to native PCRE_NOTEMPTY_ATSTART. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1915268 13f79535-47bb-0310-9956-ffa450edef68
* regex: Add ap_regexec_ex() which can take a starting offset to match from.Yann Ylavic2024-01-161-8/+23
| | | | | | | | | | | | | | | | | * include/ap_mmn.h: Bump MMN minor. * include/ap_regex.h: Declare ap_regexec_ex(). * server/util_pcre.c(ap_regexec, ap_regexec_len, ap_regexec_ex): Reuse existing ap_regexec_len() code to implement ap_regexec_ex() where the offset is given instead of zero, then implement ap_regexec{,len}() in terms of ap_regexec_ex(). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1915267 13f79535-47bb-0310-9956-ffa450edef68
* util_filter: More useful logging for brigade setaside/reinstate/adopt.Yann Ylavic2023-07-071-37/+49
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1910846 13f79535-47bb-0310-9956-ffa450edef68
* http_protocol: make request processing more robust for incomplete dataStefan Eissing2023-06-211-0/+7
| | | | | | | | | - Length restrictions may error on a too long request path, leaving the uri unset. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1910533 13f79535-47bb-0310-9956-ffa450edef68
* *) http_protocol: if there is a request and an error bucket in the inputStefan Eissing2023-06-211-62/+71
| | | | | | | | | | brigade, always process the request bucket first. This gives the proper context in which to evaluate the error bucket in. Some error access r->method, for example, in their response body. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1910530 13f79535-47bb-0310-9956-ffa450edef68
* *) mod_http2: added support for bootstrapping WebSockets via HTTP/2, asStefan Eissing2023-06-201-0/+30
| | | | | | | | | | | | | | | described in RFC 8441. A new directive 'H2WebSockets on|off' has been added. The feature is by default not enabled. As also discussed in the manual, this feature should work for setups using "ProxyPass backend-url upgrade=websocket" without further changes. Special server modules for WebSockets will have to be adapted, most likely, as the handling if IO events is different with HTTP/2. HTTP/2 WebSockets are supported on platforms with native pipes. This excludes Windows. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1910507 13f79535-47bb-0310-9956-ffa450edef68
* * Fix copy and paste errorRuediger Pluem2023-06-091-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1910324 13f79535-47bb-0310-9956-ffa450edef68
* When we are at flush_max_threshold and the next bucket is a metadata (i.e. ↵Christophe Jaillet2023-05-211-30/+30
| | | | | | | | next->length == 0), we still need to re-check for flush_max_threshold and associated optimisation (is_in_memory_bucket()) when we process this metadata bucket in the next iteration of the loop. Follow-up to r1892450. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1909966 13f79535-47bb-0310-9956-ffa450edef68
* Make sources build with latest clang versionStefan Eissing2023-04-275-5/+7
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1909450 13f79535-47bb-0310-9956-ffa450edef68
* core: Add the token_checker hook, that allows authentication to takeGraham Leggett2023-04-251-0/+29
| | | | | | | | place using mechanisms other than username/password, such as bearer tokens. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1909409 13f79535-47bb-0310-9956-ffa450edef68
* Follow up to r1909356: c89/style fix.Yann Ylavic2023-04-231-4/+4
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1909368 13f79535-47bb-0310-9956-ffa450edef68
* core: Restore original regex value when nesting Location,Graham Leggett2023-04-221-0/+14
| | | | | | | Directory and File directives. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1909356 13f79535-47bb-0310-9956-ffa450edef68
* core: Be explicit if an enclosing directive contains a path or aGraham Leggett2023-04-141-25/+23
| | | | | | | regex. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1909135 13f79535-47bb-0310-9956-ffa450edef68
* Fix possible NULL pointer dereference casued by apreq_param_make()Giovanni Bechis2023-04-055-0/+22
| | | | | | | | | | | | | | | The function apreq_param_make() will return NULL on failure. However NULL check are forgetten before derenference, which could lead to NULL pointer dereference. Adding NULL check to all use of apreq_param_make(). Submitted by: Zhou Qingyang <zhou1615@umn.edu> Github: closes #303 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908981 13f79535-47bb-0310-9956-ffa450edef68
* mpm_event: useful APLOG_DEBUG messages.Yann Ylavic2023-04-011-8/+10
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908883 13f79535-47bb-0310-9956-ffa450edef68
* Fix a possible null pointer dereference in ap_expr_parse()Giovanni Bechis2023-03-281-1/+4
| | | | | | | | | | | | | | | | | In ap_expr_parse(), ap_expr_yylex_init() will return 1 on failure, and ctx.scanner will remain NULL. However the return value of ap_expr_yylex_init() is not checked, and there is a dereference of ctx.scanner in following function ap_expr_yyset_extra(), which may lead to NULL pointer dereference. Fix this bug by adding return value check of ap_expr_yylex_init. Submitted by: Zhou Qingyang <zhou1615@umn.edu> Github: closes #308 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908772 13f79535-47bb-0310-9956-ffa450edef68
* check apreq_cookie_make return valueGiovanni Bechis2023-03-231-0/+4
| | | | | | | Github: closes #302 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908673 13f79535-47bb-0310-9956-ffa450edef68
* util_time: Follow up to r1908380 and r1908389: apr_strings.h not needed anymore.Yann Ylavic2023-03-201-1/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908556 13f79535-47bb-0310-9956-ffa450edef68
* core: Follow up to r1908393: comment about where ap_server_conf is set.Yann Ylavic2023-03-151-2/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908406 13f79535-47bb-0310-9956-ffa450edef68
* core: Follow up to r1908393: ap_server_conf to NULL before ap_read_config().Yann Ylavic2023-03-141-0/+2
| | | | | | | | Just to be sure.. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908394 13f79535-47bb-0310-9956-ffa450edef68
* core: Set ap_server_conf ASAP.Yann Ylavic2023-03-142-4/+7
| | | | | | | | | | | | | * server/config.c(ap_read_config): Set ap_server_conf as soon as it exists (with defaults). * server/main.c(main): Now that ap_server_conf is set by ap_read_config(), just make sure it's not NULL afterward with an ap_assert()ion. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908393 13f79535-47bb-0310-9956-ffa450edef68
* log: Follow up to r1908388: ap_server_conf might be NULL.Yann Ylavic2023-03-141-3/+5
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908390 13f79535-47bb-0310-9956-ffa450edef68
* util_time: Follow up to r1908380: Avoid apr_snprintf() like others.Yann Ylavic2023-03-141-6/+10
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908389 13f79535-47bb-0310-9956-ffa450edef68
* core: Use the main ErrorLogFormat for ap_log_perror() and while loading vhosts.Yann Ylavic2023-03-142-1/+13
| | | | | | | | | | | | | | * server/core.c(create_core_server_config): Init sconf->error_log_format early so that it applies while the vhost is loading. * server/log.c(log_error_core): Get the core_server_config from the main server if no server/config is provided. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908388 13f79535-47bb-0310-9956-ffa450edef68
* util_time: Note/comments about ap_recent_ctime_ex() correctness wrt trailing \0Yann Ylavic2023-03-141-2/+4
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908383 13f79535-47bb-0310-9956-ffa450edef68
* core: Add formats %{z} and %{strftime-format} to ErrorLogFormat. PR 62161.Yann Ylavic2023-03-142-10/+48
| | | | | | | | | | | | | | | | | | | %{z} prints the timezone offset (i.e. "[+-]nnnn") and %{strftime-format} allows any %-format handled by [apr_]strftime(). * include/util_time.h(): Define new AP_CTIME_OPTION_GMTOFF option for ap_recent_ctime_ex(). * server/util_time.c(ap_recent_ctime_ex): Handle AP_CTIME_OPTION_GMTOFF to print "[+-]nnnn" timezone. * server/log.c(log_ctime): If the format contains a '%' it's for strftime(), otherwise it's builtin with new 'z' as AP_CTIME_OPTION_GMTOFF. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908380 13f79535-47bb-0310-9956-ffa450edef68
* fail on bad headerEric Covener2023-01-101-0/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1906539 13f79535-47bb-0310-9956-ffa450edef68
* * Log URI causing to exceed the limit to ease analysisRuediger Pluem2023-01-041-4/+10
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1906380 13f79535-47bb-0310-9956-ffa450edef68
* * Optimize code flowRuediger Pluem2023-01-041-17/+19
| | | | | | | This whole code is only needed if have a loglevel of at least DEBUG. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1906379 13f79535-47bb-0310-9956-ffa450edef68
* * Use apr_size_t instead of int to harden against overflows.Ruediger Pluem2022-08-251-2/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1903680 13f79535-47bb-0310-9956-ffa450edef68
* core: Follow up to r1902728: ap_max_mem_free early setting.Yann Ylavic2022-08-181-1/+1
| | | | | | | | | Set ap_max_mem_free at static initialization time so that the main thread, created early from init_process(), has some (default) limits for its pool. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1903523 13f79535-47bb-0310-9956-ffa450edef68
* core: Follow up to r1902728 and r1902909: Move comment where relevant.Yann Ylavic2022-08-181-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1903522 13f79535-47bb-0310-9956-ffa450edef68
* core: Follow up to r1902728 and r1902906: simplify for APR-1.8+.Yann Ylavic2022-07-211-15/+2
| | | | | | | | apr_threadattr_max_free_set() is now in APR-1.8.x. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902909 13f79535-47bb-0310-9956-ffa450edef68
* core: Follow up to r1902728: pools may have no allocator with APR_POOL_DEBUG.Yann Ylavic2022-07-211-12/+31
| | | | | | | | | | | | With APR <= 1.7 and APR_POOL_DEBUG, thread's pools don't necessarily have an allocator, so avoid apr_allocator_max_free_set(NULL) in ap_thread_create() and ap_thread_main_create(). Also, always create an allocator in ap_thread_current_create(). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902906 13f79535-47bb-0310-9956-ffa450edef68
* util_cpre: Follow up to r1902731: Simplify thread pool allocation.Yann Ylavic2022-07-191-64/+21
| | | | | | | | | | | We don't need to over-allocate pool/heap buffers and handle the (used) size, let apr_palloc() do this exact work for us. That way we only need an AP_THREAD_LOCAL pool with no buffer tracking, simpler. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902858 13f79535-47bb-0310-9956-ffa450edef68
* util: Follow up to r1902728 and r1902731: static/AP_THREAD_LOCAL order matters.Yann Ylavic2022-07-152-2/+2
| | | | | | | | gcc seems to want "static __thread" instead of "__thread static".. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902733 13f79535-47bb-0310-9956-ffa450edef68
* util_pcre: Restore nmatch < ncaps behaviour with PCRE1 (only).Yann Ylavic2022-07-151-0/+26
| | | | | | | | | | | | | | When the requested nmatch is below the number of captures for the regex (i.e. nmatch is zero if the user does not care about the captures), with PCRE1 we can pass a smaller ovector to pcre_exec() (or even NULL) which allows for somes optimizations (less or even no recursion) internally in pcre. This might avoid crashes due to stack usage/exhaustion with pathological patterns (see BZ 66119). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902732 13f79535-47bb-0310-9956-ffa450edef68
* util_pcre: Add a thread local subpool cache for when stack does not suffice.Yann Ylavic2022-07-151-61/+164
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When AP_HAS_THREAD_LOCAL is available, use a thread-local match_thread_state to save per-thread data in a subpool of the thread's pool. If private_malloc() gets out of the stack buffer and the current thread has a pool (i.e. ap_thread_current() != NULL), it will apr_palloc()ate and return memory from the subpool. When the match is complete and the match_data are freed, the thread subpool is cleared thus giving back the memory to the allocator, which itself will give back the memory or recycle it depending on its max_free setting. * util_pcre.c: Restore POSIX_MALLOC_THRESHOLDsince this is part of the user API. * util_pcre.c(match_data_pt): Type not used (explicitely) anymore, axe. * util_pcre.c(struct match_data_state): Put the stack buffer there to simplify code (the state is allocated on stack anyway). If APREG_USE_THREAD_LOCAL, add the apr_thread_t* and match_thread_state* fields that track the thread local data for the match. * util_pcre.c(alloc_match_data, free_match): Renamed to setup_state() and cleanup_state(), simplified (no stack buffer parameters anymore). cleanup_state() now clears the thread local subpool if used during the match. setup_state() set state->thd to ap_thread_current(), thus NULL if it's not a suitable thread for using thread local data. * util_pcre.c(private_malloc): Fix a possible buf_used overflow (size <= avail < APR_ALIGN_DEFAULT(size)). Create the thread local subpool (once per thread) and allocate from there when stack space is missing and state->thd != NULL, otherwise fall back to malloc() still. * util_pcre.c(private_free): Do nothing for thread local subpool memory, will be freed in cleanup_state eventually. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902731 13f79535-47bb-0310-9956-ffa450edef68
* core: Apply ap_max_mem_free to created threads' pool allocator.Yann Ylavic2022-07-151-53/+62
| | | | | | | | | | | | | | | | | | Since APR does not set the threshold above which the allocator of the thread's starts returning its memory to the system, so set ap_max_mem_free from ap_thread_create(), ap_thread_main_create() and ap_thread_current_create(). * include/httpd.h: Provide our own ap_thread_create() in any case (but !APR_HAS_THREADS). Simplify #ifdef-ery. * server/util.c(thread_start, ap_thread_main_create, ap_thread_current_create): Set ap_max_mem_free to the thread's pool allocator. Simplify #ifdef-ery. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902728 13f79535-47bb-0310-9956-ffa450edef68
* mpm_winnt: Follow up to r1902636: another compilation error.Yann Ylavic2022-07-111-1/+1
| | | | | | | | Same error, elsewhere. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902641 13f79535-47bb-0310-9956-ffa450edef68
* mpm_winnt: Fix compilation error.Yann Ylavic2022-07-101-1/+1
| | | | | | | | server\mpm\winnt\child.c(1210,1): error C2440: 'initializing': cannot convert from 'worker_info' to 'worker_info *' git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902636 13f79535-47bb-0310-9956-ffa450edef68
* Follow-up to r1902572: Remove now unused #include.Ivan Zhakov2022-07-081-1/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902573 13f79535-47bb-0310-9956-ffa450edef68
* Rewrite ap_regexec() without a thread-local storage context for allocations.Ivan Zhakov2022-07-081-101/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide custom malloc() and free() implementations that use a stack buffer for first N bytes and then fall back to an ordinary malloc/free(). The key properties of this approach are: 1) Allocations with PCRE2 happen the same way as they were happening with PCRE1 in httpd 2.4.52 and earlier. 2) There are no malloc()/free() calls for typical cases where the match data can be kept on stack. 3) The patch avoids a malloc() for the match_data structure itself, because the match data is allocated with the provided custom malloc() function. 4) Using custom allocation functions should ensure that PCRE is not going to use malloc() for any auxiliary allocations, if they are necessary. 5) There is no per-thread state. References: 1) https://lists.apache.org/thread/l6m7dqjkk0yy3tooyd2so0rb20jmtpwd 2) https://lists.apache.org/thread/5k9y264whn4f1ll35tvl2164dz0wphvy git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902572 13f79535-47bb-0310-9956-ffa450edef68
* better error messageGiovanni Bechis2022-06-281-1/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902324 13f79535-47bb-0310-9956-ffa450edef68
* check apr_sockaddr_info_get return valueGiovanni Bechis2022-06-281-1/+6
| | | | | | | bz #66136 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1902318 13f79535-47bb-0310-9956-ffa450edef68
* core: log_tid support on FreeBSD.Yann Ylavic2022-06-161-2/+8
| | | | | | | | | | | Use pthread_getthreadid_np() when available. BZ: 65835 Submitted by: David CARLIER <devnexen gmail.com> git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1901975 13f79535-47bb-0310-9956-ffa450edef68
* mpm_prefork: Do not access the POD in ONE_PROCESS mode.Yann Ylavic2022-06-161-8/+6
| | | | | | | | | | | | There is no POD created in ONE_PROCESS mode, so avoid crashing in child_main() and clean_child_exit(). While at it, remove a dead code path in prefork_run() which is never reached since the one_process path already returns/exits above. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1901974 13f79535-47bb-0310-9956-ffa450edef68
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 01:11:24 +0100