diff options
| author | softwarefactory-project-zuul[bot] <33884098+softwarefactory-project-zuul[bot]@users.noreply.github.com> | 2021-07-07 21:41:27 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-07 21:41:27 +0200 |
| commit | adb66610150a232ead5060980b2f9318977426b1 (patch) | |
| tree | c91f3fd3a6d67304f824bce33549a66e0340a8ec | |
| parent | Merge pull request #10575 from AlexSCorey/fixesFailingUnitTest (diff) | |
| parent | No result_traceback is blank, not null (diff) | |
| download | awx-adb66610150a232ead5060980b2f9318977426b1.tar.xz awx-adb66610150a232ead5060980b2f9318977426b1.zip | |
Merge pull request #10589 from AlanCoding/null_traceback
No result_traceback is blank, not null
I kept staring at a failure where:
cannot create resource
was expected in result_traceback, but it was blank. The job had "error" status, sure enough.
Then I re-created, sure enough, the job was right there - error status, no explanation, no traceback, no indication of what happened. We did have logs though (which I still can't fully disambiguate).
After that initial confusion, I realized this is a server-side bug. The test is happy with what happens after this change.
I can re-organize this diff if needed.
Reviewed-by: Elijah DeLee <kdelee@redhat.com>
Reviewed-by: Bianca Henderson <beeankha@gmail.com>
Reviewed-by: Shane McDonald <me@shanemcd.com>
| -rw-r--r-- | awx/main/tasks.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/awx/main/tasks.py b/awx/main/tasks.py index e07b2e5a51..1519dd7ea6 100644 --- a/awx/main/tasks.py +++ b/awx/main/tasks.py @@ -3004,7 +3004,7 @@ class AWXReceptorJob: if state_name == 'Succeeded': return res - if self.task.instance.result_traceback is None: + if not self.task.instance.result_traceback: raise RuntimeError(detail) return res |