diff options
author | John Westcott IV <32551173+john-westcott-iv@users.noreply.github.com> | 2022-07-27 15:59:09 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-07-27 15:59:09 +0200 |
commit | 734899228b02f316726439b4d427e0d4033992c3 (patch) | |
tree | f59219581c19a6e152036aaf0fb7275a48257b14 /CONTRIBUTING.md | |
parent | [FieldLookupBackend] limit iexact to string fields (#12569) (diff) | |
download | awx-734899228b02f316726439b4d427e0d4033992c3.tar.xz awx-734899228b02f316726439b4d427e0d4033992c3.zip |
Updating CONTRIBUTING guide (#12565)
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r-- | CONTRIBUTING.md | 62 |
1 files changed, 27 insertions, 35 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 535fb0db66..8b748c5935 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,16 +19,17 @@ Have questions about this document or anything not covered here? Come chat with - [Purging containers and images](#purging-containers-and-images) - [Pre commit hooks](#pre-commit-hooks) - [What should I work on?](#what-should-i-work-on) + - [Translations](#translations) - [Submitting Pull Requests](#submitting-pull-requests) -- [PR Checks run by Zuul](#pr-checks-run-by-zuul) - [Reporting Issues](#reporting-issues) +- [Getting Help](#getting-help) ## Things to know prior to submitting code - All code submissions are done through pull requests against the `devel` branch. - You must use `git commit --signoff` for any commit to be merged, and agree that usage of --signoff constitutes agreement with the terms of [DCO 1.1](./DCO_1_1.md). - Take care to make sure no merge commits are in the submission, and use `git rebase` vs `git merge` for this reason. - - If collaborating with someone else on the same branch, consider using `--force-with-lease` instead of `--force`. This will prevent you from accidentally overwriting commits pushed by someone else. For more information, see https://git-scm.com/docs/git-push#git-push---force-with-leaseltrefnamegt + - If collaborating with someone else on the same branch, consider using `--force-with-lease` instead of `--force`. This will prevent you from accidentally overwriting commits pushed by someone else. For more information, see [git push docs](https://git-scm.com/docs/git-push#git-push---force-with-leaseltrefnamegt). - If submitting a large code change, it's a good idea to join the `#ansible-awx` channel on irc.libera.chat, and talk about what you would like to do or add first. This not only helps everyone know what's going on, it also helps save time and effort, if the community decides some changes are needed. - We ask all of our community members and contributors to adhere to the [Ansible code of conduct](http://docs.ansible.com/ansible/latest/community/code_of_conduct.html). If you have questions, or need assistance, please reach out to our community team at [codeofconduct@ansible.com](mailto:codeofconduct@ansible.com) @@ -42,8 +43,7 @@ The AWX development environment workflow and toolchain uses Docker and the docke Prior to starting the development services, you'll need `docker` and `docker-compose`. On Linux, you can generally find these in your distro's packaging, but you may find that Docker themselves maintain a separate repo that tracks more closely to the latest releases. -For macOS and Windows, we recommend [Docker for Mac](https://www.docker.com/docker-mac) and [Docker for Windows](https://www.docker.com/docker-windows) -respectively. +For macOS and Windows, we recommend [Docker for Mac](https://www.docker.com/docker-mac) and [Docker for Windows](https://www.docker.com/docker-windows) respectively. For Linux platforms, refer to the following from Docker: @@ -79,17 +79,13 @@ See the [README.md](./tools/docker-compose/README.md) for docs on how to build t ### Building API Documentation -AWX includes support for building [Swagger/OpenAPI -documentation](https://swagger.io). To build the documentation locally, run: +AWX includes support for building [Swagger/OpenAPI documentation](https://swagger.io). To build the documentation locally, run: ```bash (container)/awx_devel$ make swagger ``` -This will write a file named `swagger.json` that contains the API specification -in OpenAPI format. A variety of online tools are available for translating -this data into more consumable formats (such as HTML). http://editor.swagger.io -is an example of one such service. +This will write a file named `swagger.json` that contains the API specification in OpenAPI format. A variety of online tools are available for translating this data into more consumable formats (such as HTML). http://editor.swagger.io is an example of one such service. ### Accessing the AWX web interface @@ -115,20 +111,30 @@ While you can use environment variables to skip the pre-commit hooks GitHub will ## What should I work on? +We have a ["good first issue" label](https://github.com/ansible/awx/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) we put on some issues that might be a good starting point for new contributors. + +Fixing bugs and updating the documentation are always appreciated, so reviewing the backlog of issues is always a good place to start. + For feature work, take a look at the current [Enhancements](https://github.com/ansible/awx/issues?q=is%3Aissue+is%3Aopen+label%3Atype%3Aenhancement). If it has someone assigned to it then that person is the person responsible for working the enhancement. If you feel like you could contribute then reach out to that person. -Fixing bugs, adding translations, and updating the documentation are always appreciated, so reviewing the backlog of issues is always a good place to start. For extra information on debugging tools, see [Debugging](./docs/debugging/). +**NOTES** -**NOTE** +> Issue assignment will only be done for maintainers of the project. If you decide to work on an issue, please feel free to add a comment in the issue to let others know that you are working on it; but know that we will accept the first pull request from whomever is able to fix an issue. Once your PR is accepted we can add you as an assignee to an issue upon request. -> If you work in a part of the codebase that is going through active development, your changes may be rejected, or you may be asked to `rebase`. A good idea before starting work is to have a discussion with us in the `#ansible-awx` channel on irc.libera.chat, or on the [mailing list](https://groups.google.com/forum/#!forum/awx-project). -**NOTE** +> If you work in a part of the codebase that is going through active development, your changes may be rejected, or you may be asked to `rebase`. A good idea before starting work is to have a discussion with us in the `#ansible-awx` channel on irc.libera.chat, or on the [mailing list](https://groups.google.com/forum/#!forum/awx-project). > If you're planning to develop features or fixes for the UI, please review the [UI Developer doc](./awx/ui/README.md). +### Translations + +At this time we do not accept PRs for adding additional language translations as we have an automated process for generating our translations. This is because translations require constant care as new strings are added and changed in the code base. Because of this the .po files are overwritten during every translation release cycle. We also can't support a lot of translations on AWX as its an open source project and each language adds time and cost to maintain. If you would like to see AWX translated into a new language please create an issue and ask others you know to upvote the issue. Our translation team will review the needs of the community and see what they can do around supporting additional language. + +If you find an issue with an existing translation, please see the [Reporting Issues](#reporting-issues) section to open an issue and our translation team will work with you on a resolution. + + ## Submitting Pull Requests Fixes and Features for AWX will go through the Github pull request process. Submit your pull request (PR) against the `devel` branch. @@ -152,28 +158,14 @@ We like to keep our commit history clean, and will require resubmission of pull Sometimes it might take us a while to fully review your PR. We try to keep the `devel` branch in good working order, and so we review requests carefully. Please be patient. -All submitted PRs will have the linter and unit tests run against them via Zuul, and the status reported in the PR. +When your PR is initially submitted the checks will not be run until a maintainer allows them to be. Once a maintainer has done a quick review of your work the PR will have the linter and unit tests run against them via GitHub Actions, and the status reported in the PR. -## PR Checks run by Zuul - -Zuul jobs for awx are defined in the [zuul-jobs](https://github.com/ansible/zuul-jobs) repo. - -Zuul runs the following checks that must pass: - -1. `tox-awx-api-lint` -2. `tox-awx-ui-lint` -3. `tox-awx-api` -4. `tox-awx-ui` -5. `tox-awx-swagger` - -Zuul runs the following checks that are non-voting (can not pass but serve to inform PR reviewers): +## Reporting Issues + +We welcome your feedback, and encourage you to file an issue when you run into a problem. But before opening a new issues, we ask that you please view our [Issues guide](./ISSUES.md). -1. `tox-awx-detect-schema-change` - This check generates the schema and diffs it against a reference copy of the `devel` version of the schema. - Reviewers should inspect the `job-output.txt.gz` related to the check if their is a failure (grep for `diff -u -b` to find beginning of diff). - If the schema change is expected and makes sense in relation to the changes made by the PR, then you are good to go! - If not, the schema changes should be fixed, but this decision must be enforced by reviewers. +## Getting Help -## Reporting Issues +If you require additional assistance, please reach out to us at `#ansible-awx` on irc.libera.chat, or submit your question to the [mailing list](https://groups.google.com/forum/#!forum/awx-project). -We welcome your feedback, and encourage you to file an issue when you run into a problem. But before opening a new issues, we ask that you please view our [Issues guide](./ISSUES.md). +For extra information on debugging tools, see [Debugging](./docs/debugging/). |