From 5548f7e91d74401f2f56df2c2105fedc334b30c1 Mon Sep 17 00:00:00 2001
From: sean-m-sullivan <ssulliva@redhat.com>
Date: Sun, 14 Feb 2021 17:17:04 -0600
Subject: fix default value bug

---
 awx_collection/plugins/modules/tower_ad_hoc_command.py |  2 +-
 .../plugins/modules/tower_credential_input_source.py   |  4 ++--
 awx_collection/plugins/modules/tower_job_template.py   | 18 +++++++++---------
 awx_collection/plugins/modules/tower_project.py        |  4 ++--
 4 files changed, 14 insertions(+), 14 deletions(-)

(limited to 'awx_collection/plugins/modules')

diff --git a/awx_collection/plugins/modules/tower_ad_hoc_command.py b/awx_collection/plugins/modules/tower_ad_hoc_command.py
index d952f954cf..00f16d9f13 100644
--- a/awx_collection/plugins/modules/tower_ad_hoc_command.py
+++ b/awx_collection/plugins/modules/tower_ad_hoc_command.py
@@ -118,7 +118,7 @@ def main():
         limit=dict(),
         credential=dict(required=True),
         module_name=dict(required=True),
-        module_args=dict(default=""),
+        module_args=dict(),
         forks=dict(type='int'),
         verbosity=dict(type='int', choices=['0', '1', '2', '3', '4', '5']),
         extra_vars=dict(type='dict'),
diff --git a/awx_collection/plugins/modules/tower_credential_input_source.py b/awx_collection/plugins/modules/tower_credential_input_source.py
index cdc55cb1f0..e53c632777 100644
--- a/awx_collection/plugins/modules/tower_credential_input_source.py
+++ b/awx_collection/plugins/modules/tower_credential_input_source.py
@@ -76,10 +76,10 @@ from ..module_utils.tower_api import TowerAPIModule
 def main():
     # Any additional arguments that are not fields of the item can be added here
     argument_spec = dict(
-        description=dict(default=''),
+        description=dict(),
         input_field_name=dict(required=True),
         target_credential=dict(required=True),
-        source_credential=dict(default=''),
+        source_credential=dict(),
         metadata=dict(type="dict"),
         state=dict(choices=['present', 'absent'], default='present'),
     )
diff --git a/awx_collection/plugins/modules/tower_job_template.py b/awx_collection/plugins/modules/tower_job_template.py
index c99eb73118..787c145a20 100644
--- a/awx_collection/plugins/modules/tower_job_template.py
+++ b/awx_collection/plugins/modules/tower_job_template.py
@@ -340,24 +340,24 @@ def main():
     argument_spec = dict(
         name=dict(required=True),
         new_name=dict(),
-        description=dict(default=''),
+        description=dict(),
         organization=dict(),
         job_type=dict(choices=['run', 'check']),
         inventory=dict(),
         project=dict(),
         playbook=dict(),
-        credential=dict(default=''),
-        vault_credential=dict(default=''),
+        credential=dict(),
+        vault_credential=dict(),
         custom_virtualenv=dict(),
         credentials=dict(type='list', elements='str'),
         forks=dict(type='int'),
-        limit=dict(default=''),
+        limit=dict(),
         verbosity=dict(type='int', choices=[0, 1, 2, 3, 4], default=0),
         extra_vars=dict(type='dict'),
-        job_tags=dict(default=''),
+        job_tags=dict(),
         force_handlers=dict(type='bool', default=False, aliases=['force_handlers_enabled']),
-        skip_tags=dict(default=''),
-        start_at_task=dict(default=''),
+        skip_tags=dict(),
+        start_at_task=dict(),
         timeout=dict(type='int', default=0),
         use_fact_cache=dict(type='bool', aliases=['fact_caching_enabled']),
         host_config_key=dict(),
@@ -399,11 +399,11 @@ def main():
     credential = module.params.get('credential')
     vault_credential = module.params.get('vault_credential')
     credentials = module.params.get('credentials')
-    if vault_credential != '':
+    if vault_credential:
         if credentials is None:
             credentials = []
         credentials.append(vault_credential)
-    if credential != '':
+    if credential:
         if credentials is None:
             credentials = []
         credentials.append(credential)
diff --git a/awx_collection/plugins/modules/tower_project.py b/awx_collection/plugins/modules/tower_project.py
index 015badc02b..76cef63f10 100644
--- a/awx_collection/plugins/modules/tower_project.py
+++ b/awx_collection/plugins/modules/tower_project.py
@@ -229,8 +229,8 @@ def main():
         scm_type=dict(choices=['manual', 'git', 'svn', 'insights'], default='manual'),
         scm_url=dict(),
         local_path=dict(),
-        scm_branch=dict(default=''),
-        scm_refspec=dict(default=''),
+        scm_branch=dict(),
+        scm_refspec=dict(),
         credential=dict(aliases=['scm_credential']),
         scm_clean=dict(type='bool', default=False),
         scm_delete_on_update=dict(type='bool', default=False),
-- 
cgit v1.2.3