From 05582702c6f4c671b7579cf5430b95e5f4916150 Mon Sep 17 00:00:00 2001 From: kurokobo Date: Sat, 30 Sep 2023 13:02:10 +0900 Subject: fix: make type conversions work correctly (related #14487) (#14489) Signed-off-by: kurokobo <2920259+kurokobo@users.noreply.github.com> Co-authored-by: Alan Rominger --- awx_collection/plugins/modules/settings.py | 2 +- .../integration/targets/settings/tasks/main.yml | 38 ++++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletion(-) (limited to 'awx_collection') diff --git a/awx_collection/plugins/modules/settings.py b/awx_collection/plugins/modules/settings.py index 56c0b94e5a..c911f77fcc 100644 --- a/awx_collection/plugins/modules/settings.py +++ b/awx_collection/plugins/modules/settings.py @@ -89,7 +89,7 @@ def coerce_type(module, value): if not HAS_YAML: module.fail_json(msg="yaml is not installed, try 'pip install pyyaml'") return yaml.safe_load(value) - elif value.lower in ('true', 'false', 't', 'f'): + elif value.lower() in ('true', 'false', 't', 'f'): return {'t': True, 'f': False}[value[0].lower()] try: return int(value) diff --git a/awx_collection/tests/integration/targets/settings/tasks/main.yml b/awx_collection/tests/integration/targets/settings/tasks/main.yml index 65ae45c639..5feb9ee800 100644 --- a/awx_collection/tests/integration/targets/settings/tasks/main.yml +++ b/awx_collection/tests/integration/targets/settings/tasks/main.yml @@ -1,4 +1,42 @@ --- +- name: Initialize starting project vvv setting to false + awx.awx.settings: + name: "PROJECT_UPDATE_VVV" + value: false + +- name: Change project vvv setting to true + awx.awx.settings: + name: "PROJECT_UPDATE_VVV" + value: true + register: result + +- name: Changing setting to true should have changed the value + assert: + that: + - "result is changed" + +- name: Change project vvv setting to true + awx.awx.settings: + name: "PROJECT_UPDATE_VVV" + value: true + register: result + +- name: Changing setting to true again should not change the value + assert: + that: + - "result is not changed" + +- name: Change project vvv setting back to false + awx.awx.settings: + name: "PROJECT_UPDATE_VVV" + value: false + register: result + +- name: Changing setting back to false should have changed the value + assert: + that: + - "result is changed" + - name: Set the value of AWX_ISOLATION_SHOW_PATHS to a baseline settings: name: AWX_ISOLATION_SHOW_PATHS -- cgit v1.2.3