diff options
| author | paco <paco@voltanet.io> | 2018-06-19 10:17:03 +0200 |
|---|---|---|
| committer | paco <paco@voltanet.io> | 2018-06-19 10:19:05 +0200 |
| commit | 5f18adf01baeef33c6c85e3691822ee61424f238 (patch) | |
| tree | 6981816997dd395e689366dcc0a031962c541622 | |
| parent | Merge pull request #2476 from pacovn/Coverity_1433544_Explicit_null_dereferenced (diff) | |
| download | frr-5f18adf01baeef33c6c85e3691822ee61424f238.tar.xz frr-5f18adf01baeef33c6c85e3691822ee61424f238.zip | |
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
Assignment of function parameter has no effect outside the function.
Signed-off-by: F. Aragon <paco@voltanet.io>
| -rw-r--r-- | eigrpd/eigrp_packet.c | 2 | ||||
| -rw-r--r-- | isisd/isis_adjacency.c | 3 | ||||
| -rw-r--r-- | lib/frr_pthread.c | 1 | ||||
| -rw-r--r-- | ospfd/ospf_packet.c | 2 |
4 files changed, 0 insertions, 8 deletions
diff --git a/eigrpd/eigrp_packet.c b/eigrpd/eigrp_packet.c index 59864532c..fab21e520 100644 --- a/eigrpd/eigrp_packet.c +++ b/eigrpd/eigrp_packet.c @@ -944,8 +944,6 @@ void eigrp_packet_free(struct eigrp_packet *ep) THREAD_OFF(ep->t_retrans_timer); XFREE(MTYPE_EIGRP_PACKET, ep); - - ep = NULL; } /* EIGRP Header verification. */ diff --git a/isisd/isis_adjacency.c b/isisd/isis_adjacency.c index 81495d0a7..4b3d78421 100644 --- a/isisd/isis_adjacency.c +++ b/isisd/isis_adjacency.c @@ -288,7 +288,6 @@ void isis_adj_state_change(struct isis_adjacency *adj, if (del) isis_delete_adj(adj); - adj = NULL; } else if (circuit->circ_type == CIRCUIT_T_P2P) { del = false; for (level = IS_LEVEL_1; level <= IS_LEVEL_2; level++) { @@ -326,8 +325,6 @@ void isis_adj_state_change(struct isis_adjacency *adj, if (del) isis_delete_adj(adj); - - adj = NULL; } return; diff --git a/lib/frr_pthread.c b/lib/frr_pthread.c index 36a89168c..00681b9db 100644 --- a/lib/frr_pthread.c +++ b/lib/frr_pthread.c @@ -269,7 +269,6 @@ static int fpt_halt(struct frr_pthread *fpt, void **res) { thread_add_event(fpt->master, &fpt_finish, fpt, 0, NULL); pthread_join(fpt->thread, res); - fpt = NULL; return 0; } diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c index 1f67c0d5a..486ef3335 100644 --- a/ospfd/ospf_packet.c +++ b/ospfd/ospf_packet.c @@ -144,8 +144,6 @@ void ospf_packet_free(struct ospf_packet *op) stream_free(op->s); XFREE(MTYPE_OSPF_PACKET, op); - - op = NULL; } struct ospf_fifo *ospf_fifo_new() |