summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorQuentin Young <qlyoung@users.noreply.github.com>2019-09-03 20:55:38 +0200
committerGitHub <noreply@github.com>2019-09-03 20:55:38 +0200
commit68376178e557809bcba7b5e0d078442e00beeef1 (patch)
treefd29e0ee23c2aa8a44cddfce662341cee801b310
parentMerge pull request #4604 from opensourcerouting/mutex-sugar (diff)
parentzebra/fpm: deprecation warning for protobuf (diff)
downloadfrr-68376178e557809bcba7b5e0d078442e00beeef1.tar.xz
frr-68376178e557809bcba7b5e0d078442e00beeef1.zip
Merge pull request #4919 from opensourcerouting/config-warnings
build: error out on implicit missing libcap, warn for protobuf FPM
-rwxr-xr-xconfigure.ac14
-rw-r--r--zebra/zebra_fpm.c3
2 files changed, 17 insertions, 0 deletions
diff --git a/configure.ac b/configure.ac
index a940739ae..6c1b35b5f 100755
--- a/configure.ac
+++ b/configure.ac
@@ -2038,6 +2038,20 @@ if test "${enable_capabilities}" != "no"; then
-o x"${frr_ac_lcaps}" = x"yes"; then
AC_DEFINE([HAVE_CAPABILITIES], [1], [capabilities])
fi
+
+ case "$host_os" in
+ linux*)
+ if test "$frr_ac_lcaps" != "yes"; then
+ AC_MSG_ERROR([libcap and/or its headers were not found. Running FRR without libcap support built in causes a huge performance penalty.])
+ fi
+ ;;
+ esac
+else
+ case "$host_os" in
+ linux*)
+ AC_MSG_WARN([Running FRR without libcap support built in causes a huge performance penalty.])
+ ;;
+ esac
fi
AC_SUBST([LIBCAP])
diff --git a/zebra/zebra_fpm.c b/zebra/zebra_fpm.c
index eaf43095b..4144c0afe 100644
--- a/zebra/zebra_fpm.c
+++ b/zebra/zebra_fpm.c
@@ -1927,6 +1927,9 @@ static inline void zfpm_init_message_format(const char *format)
"FPM protobuf message format is not available");
return;
}
+ flog_warn(EC_ZEBRA_PROTOBUF_NOT_AVAILABLE,
+ "FPM protobuf message format is deprecated and scheduled to be removed. "
+ "Please convert to using netlink format or contact dev@lists.frrouting.org with your use case.");
zfpm_g->message_format = ZFPM_MSG_FORMAT_PROTOBUF;
return;
}