summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilippe Guibert <philippe.guibert@6wind.com>2023-09-04 15:43:37 +0200
committerPhilippe Guibert <philippe.guibert@6wind.com>2023-11-30 14:17:46 +0100
commit427d3f81f4a8c040b52ecb2e1d7ba4224b2d069c (patch)
treed2a94930269fb27370c1ca3aab63faaaa8290c08
parentsharpd: fix deleting nhid when suppressing nexthop from nh group (diff)
downloadfrr-427d3f81f4a8c040b52ecb2e1d7ba4224b2d069c.tar.xz
frr-427d3f81f4a8c040b52ecb2e1d7ba4224b2d069c.zip
zebra: clarify error when calling zebra_nhg_rib_find_nhe()
Display a specific log message when the rt_nhe parameter is not set at all. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
-rw-r--r--zebra/zebra_nhg.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/zebra/zebra_nhg.c b/zebra/zebra_nhg.c
index c38203df0..c172f18cf 100644
--- a/zebra/zebra_nhg.c
+++ b/zebra/zebra_nhg.c
@@ -1526,7 +1526,13 @@ zebra_nhg_rib_find_nhe(struct nhg_hash_entry *rt_nhe, afi_t rt_afi)
{
struct nhg_hash_entry *nhe = NULL;
- if (!(rt_nhe && rt_nhe->nhg.nexthop)) {
+ if (!rt_nhe) {
+ flog_err(EC_ZEBRA_TABLE_LOOKUP_FAILED,
+ "No nhg_hash_entry passed to %s", __func__);
+ return NULL;
+ }
+
+ if (!rt_nhe->nhg.nexthop) {
flog_err(EC_ZEBRA_TABLE_LOOKUP_FAILED,
"No nexthop passed to %s", __func__);
return NULL;