diff options
| author | Donatas Abraitis <donatas@opensourcerouting.org> | 2023-01-31 12:23:57 +0100 |
|---|---|---|
| committer | Donatas Abraitis <donatas@opensourcerouting.org> | 2023-01-31 12:29:24 +0100 |
| commit | 2be1c4002b5301eff3e37955b87001d18a2c0d5a (patch) | |
| tree | d33ad7b8e4cf79386a5775bdb424873b7623e3ab | |
| parent | doc: Add a documentation about commit conventions (diff) | |
| download | frr-2be1c4002b5301eff3e37955b87001d18a2c0d5a.tar.xz frr-2be1c4002b5301eff3e37955b87001d18a2c0d5a.zip | |
doc: Define why my pull request was closed
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
| -rw-r--r-- | doc/developer/workflow.rst | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst index 605525818..f49690610 100644 --- a/doc/developer/workflow.rst +++ b/doc/developer/workflow.rst @@ -368,6 +368,20 @@ There is a built-in commit linter. Basic rules: - Commit messages must start with a capital letter - Commit messages must not end with a period ``.`` +Why was my pull request closed? +------------------------------- + +Pull requests older than 180 days will be closed. Exceptions can be made for +pull requests that have active review comments, or that are awaiting other +dependent pull requests. Closed pull requests are easy to recreate, and little +work is lost by closing a pull request that subsequently needs to be reopened. + +We want to limit the total number of pull requests in flight to: + +- Maintain a clean project +- Remove old pull requests that would be difficult to rebase as the underlying code has changed over time +- Encourage code velocity + .. _license-for-contributions: License for Contributions |