diff options
| author | David Lamparter <equinox@opensourcerouting.org> | 2017-09-07 14:24:00 +0200 |
|---|---|---|
| committer | David Lamparter <equinox@opensourcerouting.org> | 2017-09-07 14:56:08 +0200 |
| commit | 7c87afac92b94cd26c1a74df0e499a7a05603aa7 (patch) | |
| tree | 873c352caa3f8abec839312e6a7172a45859cbec /bgpd/bgp_attr.h | |
| parent | bgpd: add safety check on ATTR_FLAG_BIT (diff) | |
| download | frr-7c87afac92b94cd26c1a74df0e499a7a05603aa7.tar.xz frr-7c87afac92b94cd26c1a74df0e499a7a05603aa7.zip | |
bgpd: kill bgp_attr_refcount()
This attempt at optimization has cost us more than a week's worth of
time on several people hunting down the subtle bug that it was missing
an increment on attr->lcommunity.
This is absolutely not worth the maintenance cost.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Diffstat (limited to 'bgpd/bgp_attr.h')
| -rw-r--r-- | bgpd/bgp_attr.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/bgpd/bgp_attr.h b/bgpd/bgp_attr.h index ea1e73652..d404c9046 100644 --- a/bgpd/bgp_attr.h +++ b/bgpd/bgp_attr.h @@ -241,7 +241,6 @@ extern void bgp_attr_dup(struct attr *, struct attr *); extern void bgp_attr_deep_dup(struct attr *, struct attr *); extern void bgp_attr_deep_free(struct attr *); extern struct attr *bgp_attr_intern(struct attr *attr); -extern struct attr *bgp_attr_refcount(struct attr *attr); extern void bgp_attr_unintern_sub(struct attr *); extern void bgp_attr_unintern(struct attr **); extern void bgp_attr_flush(struct attr *); |