diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2020-02-19 16:52:14 +0100 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2020-02-19 16:52:14 +0100 |
| commit | 3dbe2b6061ba07711584a87b714e76da92c4f8fa (patch) | |
| tree | 5976c7c28a57c378d50f7aab4e1f19a9e27d420c /bgpd/bgp_errors.c | |
| parent | Merge pull request #5802 from ton31337/feature/aggregate-address_origin_override (diff) | |
| download | frr-3dbe2b6061ba07711584a87b714e76da92c4f8fa.tar.xz frr-3dbe2b6061ba07711584a87b714e76da92c4f8fa.zip | |
bgpd: Add a better breadcrumb for when bgp is missconfiged
Currently During bgp open collision resolution if both
the router-id's are the same, we correctly follow
the RFC and close the connection. The problem is of course
that there is no notification of the error in configuration
to the end user other than a subtle open debug message.
Explicitly call out the miss-configuration as an error message
as that this miss-config took several hours of debugging to notice.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'bgpd/bgp_errors.c')
| -rw-r--r-- | bgpd/bgp_errors.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/bgpd/bgp_errors.c b/bgpd/bgp_errors.c index d9aba87e3..8a33ce678 100644 --- a/bgpd/bgp_errors.c +++ b/bgpd/bgp_errors.c @@ -457,6 +457,12 @@ static struct log_ref ferr_bgp_err[] = { .suggestion = "Gather data and open a Issue so that this developmental escape can be fixed, the peer should have been reset", }, { + .code = EC_BGP_ROUTER_ID_SAME, + .title = "BGP has detected a duplicate router id during collision resolution", + .description = "As part of normal collision detection for opening a connection to a peer, BGP has detected that the remote peer's router-id is the same as ours", + .suggestion = "Change one of the two router-id's", + }, + { .code = END_FERR, } }; |