summaryrefslogtreecommitdiffstats
path: root/bgpd/bgp_route.c
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@nvidia.com>2023-04-21 13:54:00 +0200
committerDonald Sharp <sharpd@nvidia.com>2023-04-21 13:54:00 +0200
commit852f96eb036a1bfba878467dc5b378d62f8c87ca (patch)
tree3680f378a5ebf9b8938018a645756d27a389aa6c /bgpd/bgp_route.c
parentMerge pull request #12933 from Orange-OpenSource/link_state (diff)
downloadfrr-852f96eb036a1bfba878467dc5b378d62f8c87ca.tar.xz
frr-852f96eb036a1bfba878467dc5b378d62f8c87ca.zip
bgpd: All paths have already de-refed rd_str
Coverity points out that rd_str has already been deref'ed in all paths leading to this spot. No need to keep at it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to '')
-rw-r--r--bgpd/bgp_route.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 7809d9b0a..40ecdbb67 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -7038,8 +7038,8 @@ int bgp_static_set_safi(afi_t afi, safi_t safi, struct vty *vty,
bgp_static->label = label;
bgp_static->prd = prd;
- if (rd_str)
- bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str);
+ bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str);
+
if (rmap_str) {
XFREE(MTYPE_ROUTE_MAP_NAME, bgp_static->rmap.name);
route_map_counter_decrement(bgp_static->rmap.map);