summaryrefslogtreecommitdiffstats
path: root/bgpd/rfapi
diff options
context:
space:
mode:
authorRenato Westphal <renato@opensourcerouting.org>2018-10-19 20:54:47 +0200
committerRenato Westphal <renato@opensourcerouting.org>2018-10-20 17:39:05 +0200
commitaec9d23fb4bdfbfe5beb4b0fd5e2f51d12777d69 (patch)
tree645e123bf3b55b35e17afe16c47e308ddc659ac0 /bgpd/rfapi
parentbgpd: fix some NULL pointer dereference bugs (diff)
downloadfrr-aec9d23fb4bdfbfe5beb4b0fd5e2f51d12777d69.tar.xz
frr-aec9d23fb4bdfbfe5beb4b0fd5e2f51d12777d69.zip
bgpd: fix crashes caused by missing input validation
The rfapi code wasn't checking if strtoul() succeeded or not when parsing the list of labels. Fix the affected commands by not allowing the user to enter a non-numeric input. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Diffstat (limited to 'bgpd/rfapi')
-rw-r--r--bgpd/rfapi/bgp_rfapi_cfg.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/bgpd/rfapi/bgp_rfapi_cfg.c b/bgpd/rfapi/bgp_rfapi_cfg.c
index 3c472dda4..e4e676061 100644
--- a/bgpd/rfapi/bgp_rfapi_cfg.c
+++ b/bgpd/rfapi/bgp_rfapi_cfg.c
@@ -3475,7 +3475,7 @@ DEFUN (vnc_l2_group_lni,
DEFUN (vnc_l2_group_labels,
vnc_l2_group_labels_cmd,
- "labels LABELLIST...",
+ "labels (0-1048575)...",
"Specify label values associated with group\n"
"Space separated list of label values <0-1048575>\n")
{
@@ -3509,7 +3509,7 @@ DEFUN (vnc_l2_group_labels,
DEFUN (vnc_l2_group_no_labels,
vnc_l2_group_no_labels_cmd,
- "no labels LABELLIST...",
+ "no labels (0-1048575)...",
NO_STR
"Specify label values associated with L2 group\n"
"Space separated list of label values <0-1048575>\n")