ldpd: convert cli and get rid of the xml interface

The xml2cli.pl script was useful years ago when the vty code was very
rudimentary. This is not the case anymore, so convert all ldpd CLI
commands to use DEFUNs directly and get rid of the XML interface.

The benefits are:
* Consistency with the other daemons;
* One less build dependency (the LibXML perl module);
* Easier to add new commands.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

6 files changed, 5 insertions, 17 deletions

diff --git a/doc/Building_FRR_on_Fedora24.md b/doc/Building_FRR_on_Fedora24.md
index 1f5f12b9c..bb5b52c62 100644
--- a/doc/Building_FRR_on_Fedora24.md
+++ b/doc/Building_FRR_on_Fedora24.md
@@ -8,8 +8,7 @@ Add packages:
 
     sudo dnf install git autoconf automake libtool make gawk \
        readline-devel texinfo net-snmp-devel groff pkgconfig \
-       json-c-devel pam-devel perl-XML-LibXML c-ares-devel \
-       python3-devel
+       json-c-devel pam-devel c-ares-devel python3-devel
 
 Get FRR, compile it and install it (from Git)
 ---------------------------------------------
diff --git a/doc/Building_FRR_on_NetBSD6.md b/doc/Building_FRR_on_NetBSD6.md
index 542a7f489..2e453da66 100644
--- a/doc/Building_FRR_on_NetBSD6.md
+++ b/doc/Building_FRR_on_NetBSD6.md
@@ -18,7 +18,7 @@ Configure Package location:
 Add packages:
 
     sudo pkg_add git autoconf automake libtool gmake gawk openssl \
-       pkg-config json-c p5-XML-LibXML python27 py27-test python35
+       pkg-config json-c python27 py27-test python35
 
 Install SSL Root Certificates (for git https access):
 
diff --git a/doc/Building_FRR_on_NetBSD7.md b/doc/Building_FRR_on_NetBSD7.md
index 821a6109f..f5f99d9ba 100644
--- a/doc/Building_FRR_on_NetBSD7.md
+++ b/doc/Building_FRR_on_NetBSD7.md
@@ -12,7 +12,7 @@ Install required packages
 -------------------------
 
     sudo pkgin install git autoconf automake libtool gmake gawk openssl \
-       pkg-config json-c p5-XML-LibXML python27 py27-test python35
+       pkg-config json-c python27 py27-test python35
 
 Install SSL Root Certificates (for git https access):
 
diff --git a/doc/Building_FRR_on_OmniOS.md b/doc/Building_FRR_on_OmniOS.md
index 2e9871467..7e75bda9e 100644
--- a/doc/Building_FRR_on_OmniOS.md
+++ b/doc/Building_FRR_on_OmniOS.md
@@ -47,12 +47,6 @@ Add libjson to Solaris equivalent of ld.so.conf
 
     crle -l /opt/csw/lib -u
 
-Add Perl packages:
-
-    cpan
-    cpan[1]> install XML::LibXML
-    cpan[2]> exit
-
 Add pytest:
 
     pip install pytest
diff --git a/doc/Building_FRR_on_OpenBSD6.md b/doc/Building_FRR_on_OpenBSD6.md
index 1c07b41ad..e9e103051 100644
--- a/doc/Building_FRR_on_OpenBSD6.md
+++ b/doc/Building_FRR_on_OpenBSD6.md
@@ -11,7 +11,7 @@ Configure PKG_PATH
 Add packages:
 
     pkg_add git autoconf-2.69p2 automake-1.15p0 libtool bison
-    pkg_add gmake gawk dejagnu openssl json-c p5-XML-LibXML py-test
+    pkg_add gmake gawk dejagnu openssl json-c py-test
 
 Select Python2.7 as default (required for pytest)
 
diff --git a/doc/Building_FRR_on_Ubuntu1204.md b/doc/Building_FRR_on_Ubuntu1204.md
index e79614a57..033e05bcd 100644
--- a/doc/Building_FRR_on_Ubuntu1204.md
+++ b/doc/Building_FRR_on_Ubuntu1204.md
@@ -13,7 +13,7 @@ Add packages:
 
     apt-get install git autoconf automake libtool make gawk libreadline-dev \
        texinfo libpam0g-dev dejagnu libjson0-dev pkg-config libpam0g-dev \
-       libjson0-dev flex python-pip libc-ares-dev python3-dev libxml2 libxml2-dev
+       libjson0-dev flex python-pip libc-ares-dev python3-dev
 
 Install newer bison from 14.04 package source (Ubuntu 12.04 package source
 is too old)
@@ -51,11 +51,6 @@ Install newer version of autoconf and automake:
     sudo make install
     cd ..
 
-Install XML::LibXML
-
-    sudo cpan
-        install XML::LibXML
-
 Install pytest:
 
     pip install pytest