diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2019-12-17 16:32:37 +0100 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2019-12-17 20:57:15 +0100 |
| commit | 8bc6e6291481135c777690dd23cc0d3bc28a2ff5 (patch) | |
| tree | 09f3f2b463193777978609765ffb0384227abfa5 /doc | |
| parent | Merge pull request #5508 from ton31337/feature/show_ip_route_summary_json (diff) | |
| download | frr-8bc6e6291481135c777690dd23cc0d3bc28a2ff5.tar.xz frr-8bc6e6291481135c777690dd23cc0d3bc28a2ff5.zip | |
doc: Update workflow to include new automated testing Requirement
Update the workflow.rst file to outline new requirement for
features to include automated testing of some sort.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/developer/workflow.rst | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst index 40378f021..8ce3bdeeb 100644 --- a/doc/developer/workflow.rst +++ b/doc/developer/workflow.rst @@ -283,7 +283,10 @@ Pre-submission Checklist - ``make test`` - In the case of a major new feature or other significant change, document - plans for continued maintenance of the feature + plans for continued maintenance of the feature. In addition it is a + requirement that automated testing must be written that exercises + the new feature within our existing CI infrastructure. Also the + addition of automated testing to cover any pull request is encouraged. .. _signing-off: @@ -452,6 +455,10 @@ Guidelines for code review may originate with a reviewer or document agreement reached on Slack, the Development mailing list, or the weekly technical meeting. +- Reviewers may ask for new automated testing if they feel that the + code change is large enough/significant enough to warrant such + a requirement. + Coding Practices & Style ======================== |