diff options
| author | Donatas Abraitis <donatas.abraitis@gmail.com> | 2019-12-19 09:09:39 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-19 09:09:39 +0100 |
| commit | d8ffe9761d7b85d3760b70faaa933f62c872245e (patch) | |
| tree | d5cc9918ee675d7fb8dcd5ea24d36f2ce645beae /doc | |
| parent | Merge pull request #5561 from qlyoung/doc-update-overview (diff) | |
| parent | doc: Update workflow to include new automated testing Requirement (diff) | |
| download | frr-d8ffe9761d7b85d3760b70faaa933f62c872245e.tar.xz frr-d8ffe9761d7b85d3760b70faaa933f62c872245e.zip | |
Merge pull request #5549 from donaldsharp/automated
doc: Update workflow to include new automated testing Requirement
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/developer/workflow.rst | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst index 40378f021..8ce3bdeeb 100644 --- a/doc/developer/workflow.rst +++ b/doc/developer/workflow.rst @@ -283,7 +283,10 @@ Pre-submission Checklist - ``make test`` - In the case of a major new feature or other significant change, document - plans for continued maintenance of the feature + plans for continued maintenance of the feature. In addition it is a + requirement that automated testing must be written that exercises + the new feature within our existing CI infrastructure. Also the + addition of automated testing to cover any pull request is encouraged. .. _signing-off: @@ -452,6 +455,10 @@ Guidelines for code review may originate with a reviewer or document agreement reached on Slack, the Development mailing list, or the weekly technical meeting. +- Reviewers may ask for new automated testing if they feel that the + code change is large enough/significant enough to warrant such + a requirement. + Coding Practices & Style ======================== |