diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2017-08-31 19:01:35 +0200 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2017-09-06 00:56:40 +0200 |
| commit | 21dfc9ed509ff8571feb3bcdae57602574fca5b9 (patch) | |
| tree | 73d3f96f4df71ed1e0595b4d17a94916982af5a1 /eigrpd | |
| parent | pimd: Add usage of vty_frame for vrf configuration (diff) | |
| download | frr-21dfc9ed509ff8571feb3bcdae57602574fca5b9.tar.xz frr-21dfc9ed509ff8571feb3bcdae57602574fca5b9.zip | |
eigrpd: Clean up some new coverity issues
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'eigrpd')
| -rw-r--r-- | eigrpd/eigrp_packet.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/eigrpd/eigrp_packet.c b/eigrpd/eigrp_packet.c index 8a7d4d958..d2bff74a5 100644 --- a/eigrpd/eigrp_packet.c +++ b/eigrpd/eigrp_packet.c @@ -272,6 +272,7 @@ int eigrp_make_sha256_digest(struct eigrp_interface *ei, struct stream *s, if (!key) { zlog_warn("Interface %s: Expected key value not found in config", ei->ifp->name); + eigrp_authTLV_SHA256_free(auth_TLV); return 0; } @@ -622,8 +623,8 @@ int eigrp_read(struct thread *thread) if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { char src[PREFIX_STRLEN], dst[PREFIX_STRLEN]; - strncpy(src, inet_ntoa(iph->ip_src), PREFIX_STRLEN); - strncpy(dst, inet_ntoa(iph->ip_dst), PREFIX_STRLEN); + strlcpy(src, inet_ntoa(iph->ip_src), sizeof(src)); + strlcpy(dst, inet_ntoa(iph->ip_dst), sizeof(dst)); zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", lookup_msg(eigrp_packet_type_str, opcode, NULL), ntohl(eigrph->sequence), ntohl(eigrph->ack), length, |