diff options
| author | Igor Ryzhov <iryzhov@nfware.com> | 2021-10-30 00:49:04 +0200 |
|---|---|---|
| committer | Igor Ryzhov <iryzhov@nfware.com> | 2021-10-30 02:17:38 +0200 |
| commit | 67486f32ae23668093d282cba58ac4f9cbab1294 (patch) | |
| tree | 4eb454e3630949341f6f639a9263647407884557 /isisd/isis_cli.c | |
| parent | isisd: don't remove interface config when isis router is deleted (diff) | |
| download | frr-67486f32ae23668093d282cba58ac4f9cbab1294.tar.xz frr-67486f32ae23668093d282cba58ac4f9cbab1294.zip | |
isisd: remove useless checks when configuring passive interfaces
Currently, we have some checks in the CLI and NB layer to "protect" from
setting loopback interfaces into non-passive mode. These checks are not
correct, because we can not rely on operational data during config
reading and validation stage as this data doesn't exist yet. There's
nothing wrong in allowing "incorrect" configuration – it is already
correctly handled by the actual code.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Diffstat (limited to 'isisd/isis_cli.c')
| -rw-r--r-- | isisd/isis_cli.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/isisd/isis_cli.c b/isisd/isis_cli.c index 96ca074b8..c0727a669 100644 --- a/isisd/isis_cli.c +++ b/isisd/isis_cli.c @@ -131,7 +131,6 @@ DEFPY_YANG(ip_router_isis, ip_router_isis_cmd, const struct lyd_node *if_dnode, *inst_dnode; const char *circ_type = NULL; const char *vrf_name; - struct interface *ifp; if_dnode = yang_dnode_get(vty->candidate_config->dnode, VTY_CURR_XPATH); if (!if_dnode) { @@ -161,12 +160,6 @@ DEFPY_YANG(ip_router_isis, ip_router_isis_cmd, nb_cli_enqueue_change(vty, "./frr-isisd:isis/circuit-type", NB_OP_MODIFY, circ_type); - /* check if the interface is a loopback and if so set it as passive */ - ifp = nb_running_get_entry(NULL, VTY_CURR_XPATH, false); - if (ifp && if_is_loopback_or_vrf(ifp)) - nb_cli_enqueue_change(vty, "./frr-isisd:isis/passive", - NB_OP_MODIFY, "true"); - return nb_cli_apply_changes(vty, NULL); } @@ -188,7 +181,6 @@ DEFPY_YANG(ip6_router_isis, ip6_router_isis_cmd, const struct lyd_node *if_dnode, *inst_dnode; const char *circ_type = NULL; const char *vrf_name; - struct interface *ifp; if_dnode = yang_dnode_get(vty->candidate_config->dnode, VTY_CURR_XPATH); if (!if_dnode) { @@ -218,12 +210,6 @@ DEFPY_YANG(ip6_router_isis, ip6_router_isis_cmd, nb_cli_enqueue_change(vty, "./frr-isisd:isis/circuit-type", NB_OP_MODIFY, circ_type); - /* check if the interface is a loopback and if so set it as passive */ - ifp = nb_running_get_entry(NULL, VTY_CURR_XPATH, false); - if (ifp && if_is_loopback_or_vrf(ifp)) - nb_cli_enqueue_change(vty, "./frr-isisd:isis/passive", - NB_OP_MODIFY, "true"); - return nb_cli_apply_changes(vty, NULL); } |