summaryrefslogtreecommitdiffstats
path: root/ldpd/packet.c
diff options
context:
space:
mode:
authorRenato Westphal <renato@opensourcerouting.org>2017-04-20 00:31:19 +0200
committerRenato Westphal <renato@opensourcerouting.org>2017-06-05 17:23:48 +0200
commit9b2868bc019b15a878b3b08d165194b8c00b0e63 (patch)
tree53b6041e4d877608653d65fe055a436fa5686867 /ldpd/packet.c
parentldpd: minor changes in the output of some show commands (diff)
downloadfrr-9b2868bc019b15a878b3b08d165194b8c00b0e63.tar.xz
frr-9b2868bc019b15a878b3b08d165194b8c00b0e63.zip
ldpd: accept notifications during the session establishment process
If we don't do this, we'll never trigger the backoff exponential timer since it's impossible to distinguish between Initialization NAK's and general errors. Also: * Implement some missing bits from RFC 5036; * remove superfluous log message in session_shutdown() (send_notification() logs that we're sending a fatal notification). Regression introduced by commit 8819fc3. Fixes the following ANVL LDP regressions: 6.19 and 6.21. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Diffstat (limited to '')
-rw-r--r--ldpd/packet.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ldpd/packet.c b/ldpd/packet.c
index 46893b992..75e1a9a02 100644
--- a/ldpd/packet.c
+++ b/ldpd/packet.c
@@ -519,6 +519,8 @@ session_read(struct thread *thread)
return (0);
}
break;
+ case MSG_TYPE_NOTIFICATION:
+ break;
default:
if (nbr->state != NBR_STA_OPER) {
session_shutdown(nbr, S_SHUTDOWN,
@@ -661,8 +663,6 @@ session_shutdown(struct nbr *nbr, uint32_t status, uint32_t msg_id,
case NBR_STA_OPENREC:
case NBR_STA_OPENSENT:
case NBR_STA_OPER:
- log_debug("%s: lsr-id %s", __func__, inet_ntoa(nbr->id));
-
send_notification(nbr->tcp, status, msg_id, msg_type);
nbr_fsm(nbr, NBR_EVT_CLOSE_SESSION);