summaryrefslogtreecommitdiffstats
path: root/lib/buffer.c
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@cumulusnetworks.com>2018-08-16 19:56:44 +0200
committerDonald Sharp <sharpd@cumulusnetworks.com>2018-08-23 14:36:07 +0200
commit07436e2a526ec10355eb8aa7efc6063d8eb5eeb5 (patch)
tree0bc7607b1d2f27484bd4f740352d0844b4a7ec38 /lib/buffer.c
parentlib: Remove smux option for snmp (diff)
downloadfrr-07436e2a526ec10355eb8aa7efc6063d8eb5eeb5.tar.xz
frr-07436e2a526ec10355eb8aa7efc6063d8eb5eeb5.zip
lib: Remove zlog_warn from some places in buffer.c
zlog_warn was being used to inform user of impossible situations or for normal operations. Remove these from the code. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'lib/buffer.c')
-rw-r--r--lib/buffer.c18
1 files changed, 3 insertions, 15 deletions
diff --git a/lib/buffer.c b/lib/buffer.c
index 0292c85da..1799c6b94 100644
--- a/lib/buffer.c
+++ b/lib/buffer.c
@@ -274,19 +274,12 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
if (!b->head)
return BUFFER_EMPTY;
- if (height < 1) {
- zlog_warn(
- "%s called with non-positive window height %d, forcing to 1",
- __func__, height);
+ if (height < 1)
height = 1;
- } else if (height >= 2)
+ else if (height >= 2)
height--;
- if (width < 1) {
- zlog_warn(
- "%s called with non-positive window width %d, forcing to 1",
- __func__, width);
+ if (width < 1)
width = 1;
- }
/* For erase and more data add two to b's buffer_data count.*/
if (b->head->next == NULL) {
@@ -334,11 +327,6 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
{
iov_alloc *= 2;
if (iov != small_iov) {
- zlog_warn(
- "%s: growing iov array to %d; "
- "width %d, height %d, size %lu",
- __func__, iov_alloc, width, height,
- (unsigned long)b->size);
iov = XREALLOC(MTYPE_TMP, iov,
iov_alloc * sizeof(*iov));
} else {