diff options
| author | Olivier Dugeon <olivier.dugeon@orange.com> | 2021-10-25 11:52:19 +0200 |
|---|---|---|
| committer | Olivier Dugeon <olivier.dugeon@orange.com> | 2021-10-29 10:16:12 +0200 |
| commit | f4157b4f6e4df3bf2c008f38bc8b8e68a786463e (patch) | |
| tree | 8e44dffc0cabe0cd8b5aa68d09f178a302fd9923 /lib/link_state.h | |
| parent | Merge pull request #9670 from LabNConsulting/chopps/fix-valgrind-fail-check (diff) | |
| download | frr-f4157b4f6e4df3bf2c008f38bc8b8e68a786463e.tar.xz frr-f4157b4f6e4df3bf2c008f38bc8b8e68a786463e.zip | |
lib: Fix comparison function in link_state.c
ls_node_same, ls_attributes_same and ls_prefix_same are not producing expected
result due to a wrong usage of memcmp. In addition, if respective structures
are not initialized with 0, there is a risk that the comparison failed.
This patch correct usage of memcmp and expand comparison to each invidual
parameters of the respective structure for safer result.
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>
Diffstat (limited to 'lib/link_state.h')
| -rw-r--r-- | lib/link_state.h | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/lib/link_state.h b/lib/link_state.h index de116df89..981e8b528 100644 --- a/lib/link_state.h +++ b/lib/link_state.h @@ -94,6 +94,16 @@ struct ls_node_id { } id __attribute__((aligned(8))); }; +/** + * Check if two Link State Node IDs are equal. Note that this routine has the + * same return value sense as '==' (which is different from a comparison). + * + * @param i1 First Link State Node Identifier + * @param i2 Second Link State Node Identifier + * @return 1 if equal, 0 otherwise + */ +extern int ls_node_id_same(struct ls_node_id i1, struct ls_node_id i2); + /* Link State flags to indicate which Node parameters are valid */ #define LS_NODE_UNSET 0x0000 #define LS_NODE_NAME 0x0001 |