summaryrefslogtreecommitdiffstats
path: root/lib/vty.c
diff options
context:
space:
mode:
authorChristian Hopps <chopps@labn.net>2024-07-22 13:52:10 +0200
committerChristian Hopps <chopps@labn.net>2024-07-22 13:54:50 +0200
commit7afd7d99f2fa39be073625c630d46f96e5dd66a5 (patch)
treed81c351b7942a19e5c89eb7680a30217064d1986 /lib/vty.c
parentMerge pull request #16423 from opensourcerouting/fix/show_if_the_open_message... (diff)
downloadfrr-7afd7d99f2fa39be073625c630d46f96e5dd66a5.tar.xz
frr-7afd7d99f2fa39be073625c630d46f96e5dd66a5.zip
lib: move non-error from __log_err to __dbg
Additionally, print `errmsg_if_any` in successful debug messages if non-NULL. fixes #16386 #16043 Signed-off-by: Christian Hopps <chopps@labn.net>
Diffstat (limited to 'lib/vty.c')
-rw-r--r--lib/vty.c15
1 files changed, 9 insertions, 6 deletions
diff --git a/lib/vty.c b/lib/vty.c
index 0dcd118a9..ecb5383a5 100644
--- a/lib/vty.c
+++ b/lib/vty.c
@@ -3591,8 +3591,9 @@ static void vty_mgmt_set_config_result_notified(
vty_out(vty, "%s\n", errmsg_if_any);
} else {
debug_fe_client("SET_CONFIG request for client 0x%" PRIx64
- " req-id %" PRIu64 " was successfull",
- client_id, req_id);
+ " req-id %" PRIu64 " was successfull%s%s",
+ client_id, req_id, errmsg_if_any ? ": " : "",
+ errmsg_if_any ?: "");
}
if (implicit_commit) {
@@ -3624,8 +3625,9 @@ static void vty_mgmt_commit_config_result_notified(
vty_out(vty, "%s\n", errmsg_if_any);
} else {
debug_fe_client("COMMIT_CONFIG request for client 0x%" PRIx64
- " req-id %" PRIu64 " was successfull",
- client_id, req_id);
+ " req-id %" PRIu64 " was successfull%s%s",
+ client_id, req_id, errmsg_if_any ? ": " : "",
+ errmsg_if_any ?: "");
if (errmsg_if_any)
vty_out(vty, "MGMTD: %s\n", errmsg_if_any);
}
@@ -3656,8 +3658,9 @@ static int vty_mgmt_get_data_result_notified(
}
debug_fe_client("GET_DATA request succeeded, client 0x%" PRIx64
- " req-id %" PRIu64,
- client_id, req_id);
+ " req-id %" PRIu64 "%s%s",
+ client_id, req_id, errmsg_if_any ? ": " : "",
+ errmsg_if_any ?: "");
if (req_id != mgmt_last_req_id) {
mgmt_last_req_id = req_id;