diff options
| author | Quentin Young <qlyoung@cumulusnetworks.com> | 2019-02-25 19:51:33 +0100 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2019-02-26 00:00:16 +0100 |
| commit | d8729f8cb55d118c1937b7d001d70d6ea4476e52 (patch) | |
| tree | 0890eb18b74ac62411e8a991d0db2d1579042a46 /lib | |
| parent | Merge pull request #3864 from qlyoung/fix-ospf-mtu-warning-style (diff) | |
| download | frr-d8729f8cb55d118c1937b7d001d70d6ea4476e52.tar.xz frr-d8729f8cb55d118c1937b7d001d70d6ea4476e52.zip | |
*: use proper bool initializers & fix comparisons
- bools should be initialized with true/false
- bools do not need to be compared
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/command_graph.c | 2 | ||||
| -rw-r--r-- | lib/libfrr.c | 2 | ||||
| -rw-r--r-- | lib/northbound_confd.c | 2 | ||||
| -rw-r--r-- | lib/yang_wrappers.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/lib/command_graph.c b/lib/command_graph.c index 0e8669c4b..4757fd951 100644 --- a/lib/command_graph.c +++ b/lib/command_graph.c @@ -471,7 +471,7 @@ void cmd_graph_node_print_cb(struct graph_node *gn, struct buffer *buf) struct cmd_token *tok = gn->data; const char *color; - if (wasend == true) { + if (wasend) { wasend = false; return; } diff --git a/lib/libfrr.c b/lib/libfrr.c index 9119b0499..1afe30d61 100644 --- a/lib/libfrr.c +++ b/lib/libfrr.c @@ -61,7 +61,7 @@ static char dbfile_default[512]; #endif static char vtypath_default[256]; -bool debug_memstats_at_exit = 0; +bool debug_memstats_at_exit = false; static bool nodetach_term, nodetach_daemon; static char comb_optstr[256]; diff --git a/lib/northbound_confd.c b/lib/northbound_confd.c index a8e001781..a499d48c1 100644 --- a/lib/northbound_confd.c +++ b/lib/northbound_confd.c @@ -1383,7 +1383,7 @@ error: static int frr_confd_finish(void) { - if (confd_connected == false) + if (!confd_connected) return 0; frr_confd_finish_cdb(); diff --git a/lib/yang_wrappers.c b/lib/yang_wrappers.c index 6273dff3c..7ecea5f44 100644 --- a/lib/yang_wrappers.c +++ b/lib/yang_wrappers.c @@ -62,7 +62,7 @@ bool yang_str2bool(const char *value) struct yang_data *yang_data_new_bool(const char *xpath, bool value) { - return yang_data_new(xpath, (value == true) ? "true" : "false"); + return yang_data_new(xpath, (value) ? "true" : "false"); } bool yang_dnode_get_bool(const struct lyd_node *dnode, const char *xpath_fmt, |