diff options
| author | David Lamparter <equinox@opensourcerouting.org> | 2021-07-21 11:04:23 +0200 |
|---|---|---|
| committer | David Lamparter <equinox@opensourcerouting.org> | 2021-07-21 17:10:08 +0200 |
| commit | 63116a7008706988136785ffa011cefee0355193 (patch) | |
| tree | bb9cd12975d5560d4c3df5d2c9e5d0e32cea33cf /mlag | |
| parent | Merge pull request #8956 from pguibert6WIND/bgp_loop_through_itself (diff) | |
| download | frr-63116a7008706988136785ffa011cefee0355193.tar.xz frr-63116a7008706988136785ffa011cefee0355193.zip | |
build: fix `AM_LDFLAGS` usage (and gcov)
like the other automake variables, setting `xyz_LDFLAGS` causes
`AM_LDFLAGS` to be ignored for `xyz`. For some reason I had in my mind
that automake doesn't do this for LDFLAGS, but... it does. (Which is
consistent with `_CFLAGS` and co.)
So, all the libraries and modules have been ignoring `AM_LDFLAGS` (which
includes `SAN_FLAGS` too). Set up new `LIB_LDFLAGS` and
`MODULE_LDFLAGS` to handle all of this correctly (and move these bits to
a central location.)
Fixes: #9034
Fixes: 0c4285d77eb ("build: properly split CFLAGS from AC_CFLAGS")
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Diffstat (limited to 'mlag')
| -rw-r--r-- | mlag/subdir.am | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mlag/subdir.am b/mlag/subdir.am index 49d176150..376eea8bc 100644 --- a/mlag/subdir.am +++ b/mlag/subdir.am @@ -2,7 +2,7 @@ if HAVE_PROTOBUF3 lib_LTLIBRARIES += mlag/libmlag_pb.la endif -mlag_libmlag_pb_la_LDFLAGS = -version-info 0:0:0 +mlag_libmlag_pb_la_LDFLAGS = $(LIB_LDFLAGS) -version-info 0:0:0 mlag_libmlag_pb_la_CPPFLAGS = $(AM_CPPFLAGS) $(PROTOBUF_C_CFLAGS) mlag_libmlag_pb_la_SOURCES = \ # end |