all: added CHECK ME for DEFUNs that look at argc

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

10 files changed, 42 insertions, 0 deletions

diff --git a/ospf6d/ospf6_area.c b/ospf6d/ospf6_area.c
index d67621d7c..75c1bd2f6 100644
--- a/ospf6d/ospf6_area.c
+++ b/ospf6d/ospf6_area.c
@@ -468,6 +468,7 @@ DEFUN (area_range,
        "Specify IPv6 prefix\n"
        )
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 1;
   int idx_ipv6_prefixlen = 3;
   int ret;
@@ -571,6 +572,7 @@ DEFUN (no_area_range,
        "Configured address range\n"
        "Specify IPv6 prefix\n")
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 2;
   int ret;
   struct ospf6_area *oa;
@@ -680,6 +682,7 @@ DEFUN (area_filter_list,
        "Filter networks sent to this area\n"
        "Filter networks sent from this area\n")
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 1;
   int idx_word = 4;
   struct ospf6_area *area;
@@ -724,6 +727,7 @@ DEFUN (no_area_filter_list,
        "Filter networks sent to this area\n"
        "Filter networks sent from this area\n")
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 2;
   int idx_word = 5;
   struct ospf6_area *area;
diff --git a/ospf6d/ospf6_asbr.c b/ospf6d/ospf6_asbr.c
index 379320e86..3798f85df 100644
--- a/ospf6d/ospf6_asbr.c
+++ b/ospf6d/ospf6_asbr.c
@@ -1142,6 +1142,7 @@ DEFUN (no_set_metric,
        SET_STR
        "Metric value for destination routing protocol\n")
 {
+  /* CHECK ME argc referenced below */
   int ret = 0;
 
   if (argc == 0)
diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index e9d66419d..e15fb9971 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1006,6 +1006,7 @@ DEFUN (show_ipv6_ospf6_interface,
        IFNAME_STR
        )
 {
+  /* CHECK ME argc referenced below */
   int idx_ifname = 4;
   struct interface *ifp;
   struct listnode *i;
@@ -1069,6 +1070,7 @@ DEFUN (show_ipv6_ospf6_interface_ifname_prefix,
        "Display connected prefixes to advertise\n"
        )
 {
+  /* CHECK ME argc referenced below */
   int idx_ifname = 4;
   struct interface *ifp;
   struct ospf6_interface *oi;
@@ -1131,6 +1133,7 @@ DEFUN (show_ipv6_ospf6_interface_prefix,
        "Display connected prefixes to advertise\n"
        )
 {
+  /* CHECK ME argc referenced below */
   struct listnode *i;
   struct ospf6_interface *oi;
   struct interface *ifp;
@@ -1990,6 +1993,7 @@ DEFUN (clear_ipv6_ospf6_interface,
        IFNAME_STR
        )
 {
+  /* CHECK ME argc referenced below */
   int idx_ifname = 4;
   struct interface *ifp;
   struct listnode *node;
diff --git a/ospf6d/ospf6_lsa.c b/ospf6d/ospf6_lsa.c
index a70e450f6..7aa78048d 100644
--- a/ospf6d/ospf6_lsa.c
+++ b/ospf6d/ospf6_lsa.c
@@ -835,6 +835,7 @@ DEFUN (debug_ospf6_lsa_type,
        "Specify LS type as Hexadecimal\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 3;
   unsigned int i;
   struct ospf6_lsa_handler *handler = NULL;
@@ -893,6 +894,7 @@ DEFUN (no_debug_ospf6_lsa_type,
        "Specify LS type as Hexadecimal\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   u_int i;
   struct ospf6_lsa_handler *handler = NULL;
diff --git a/ospf6d/ospf6_message.c b/ospf6d/ospf6_message.c
index 2cedc59ee..8c4684081 100644
--- a/ospf6d/ospf6_message.c
+++ b/ospf6d/ospf6_message.c
@@ -2371,6 +2371,7 @@ DEFUN (debug_ospf6_message,
        "Debug All message\n"
        )
 {
+  /* CHECK ME argc referenced below */
   int idx_packet = 3;
   unsigned char level = 0;
   int type = 0;
@@ -2450,6 +2451,7 @@ DEFUN (no_debug_ospf6_message,
        "Debug All message\n"
        )
 {
+  /* CHECK ME argc referenced below */
   int idx_packet = 4;
   unsigned char level = 0;
   int type = 0;
diff --git a/ospf6d/ospf6_neighbor.c b/ospf6d/ospf6_neighbor.c
index 76c3862ec..573fced39 100644
--- a/ospf6d/ospf6_neighbor.c
+++ b/ospf6d/ospf6_neighbor.c
@@ -848,6 +848,7 @@ DEFUN (show_ipv6_ospf6_neighbor,
        "Neighbor list\n"
       )
 {
+  /* CHECK ME argc referenced below */
   struct ospf6_neighbor *on;
   struct ospf6_interface *oi;
   struct ospf6_area *oa;
@@ -945,6 +946,7 @@ DEFUN (debug_ospf6_neighbor,
        "Debug OSPFv3 Neighbor\n"
       )
 {
+  /* CHECK ME argc referenced below */
   unsigned char level = 0;
   if (argc)
     {
@@ -982,6 +984,7 @@ DEFUN (no_debug_ospf6_neighbor,
        "Debug OSPFv3 Neighbor\n"
       )
 {
+  /* CHECK ME argc referenced below */
   unsigned char level = 0;
   if (argc)
     {
diff --git a/ospf6d/ospf6_spf.c b/ospf6d/ospf6_spf.c
index 3aa653814..659078353 100644
--- a/ospf6d/ospf6_spf.c
+++ b/ospf6d/ospf6_spf.c
@@ -885,6 +885,7 @@ DEFUN (ospf6_timers_throttle_spf,
        "Initial hold time (msec) between consecutive SPF calculations\n"
        "Maximum hold time (msec)\n")
 {
+  /* CHECK ME argc referenced below */
   int idx_number = 3;
   int idx_number_2 = 4;
   int idx_number_3 = 5;
diff --git a/ospf6d/ospf6_top.c b/ospf6d/ospf6_top.c
index 5fef06d7c..49e136c99 100644
--- a/ospf6d/ospf6_top.c
+++ b/ospf6d/ospf6_top.c
@@ -405,6 +405,7 @@ DEFUN (ospf6_timers_lsa,
        "Minimum delay in receiving new version of a LSA\n"
        "Delay in milliseconds\n")
 {
+  /* CHECK ME argc referenced below */
   int idx_number = 3;
   unsigned int minarrival;
   struct ospf6 *ospf = vty->index;
@@ -443,6 +444,7 @@ DEFUN (no_ospf6_timers_lsa,
        "OSPF6 LSA timers\n"
        "Minimum delay in receiving new version of a LSA\n")
 {
+  /* CHECK ME argc referenced below */
   unsigned int minarrival;
   struct ospf6 *ospf = vty->index;
 
@@ -816,6 +818,7 @@ DEFUN (show_ipv6_ospf6_route,
        ROUTE_STR
        )
 {
+  /* CHECK ME argc referenced below */
   OSPF6_CMD_CHECK_RUNNING ();
 
   ospf6_route_table_show (vty, argc, argv, ospf6->route_table);
@@ -846,6 +849,7 @@ DEFUN (show_ipv6_ospf6_route_match,
        "Display routes which match the specified route\n"
        )
 {
+  /* CHECK ME argc referenced below */
   OSPF6_CMD_CHECK_RUNNING ();
 
   ospf6_route_table_show (vty, argc, argv, ospf6->route_table);
@@ -864,6 +868,7 @@ DEFUN (show_ipv6_ospf6_route_match_detail,
        "Detailed information\n"
        )
 {
+  /* CHECK ME argc referenced below */
   OSPF6_CMD_CHECK_RUNNING ();
 
   ospf6_route_table_show (vty, argc, argv, ospf6->route_table);
@@ -886,6 +891,7 @@ DEFUN (show_ipv6_ospf6_route_type_detail,
        "Detailed information\n"
        )
 {
+  /* CHECK ME argc referenced below */
   OSPF6_CMD_CHECK_RUNNING ();
 
   ospf6_route_table_show (vty, argc, argv, ospf6->route_table);
diff --git a/ospf6d/ospf6_zebra.c b/ospf6d/ospf6_zebra.c
index 6599fbc6c..44d1bbfaf 100644
--- a/ospf6d/ospf6_zebra.c
+++ b/ospf6d/ospf6_zebra.c
@@ -726,6 +726,7 @@ DEFUN (debug_ospf6_zebra_sendrecv,
        "Debug Receiving zebra\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_send_recv = 3;
   unsigned char level = 0;
 
@@ -766,6 +767,7 @@ DEFUN (no_debug_ospf6_zebra_sendrecv,
        "Debug Receiving zebra\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_send_recv = 4;
   unsigned char level = 0;
 
diff --git a/ospf6d/ospf6d.c b/ospf6d/ospf6d.c
index b57228885..c67b0878c 100644
--- a/ospf6d/ospf6d.c
+++ b/ospf6d/ospf6d.c
@@ -187,6 +187,7 @@ DEFUN (show_ipv6_ospf6_database,
        "Display Link state database\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int level;
   struct listnode *i, *j;
   struct ospf6 *o = ospf6;
@@ -264,6 +265,7 @@ DEFUN (show_ipv6_ospf6_database_type,
        "Display Intra-Area-Prefix LSAs\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int level;
   struct listnode *i, *j;
   struct ospf6 *o = ospf6;
@@ -364,6 +366,7 @@ DEFUN (show_ipv6_ospf6_database_id,
        "Specify Link state ID as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 5;
   int level;
   struct listnode *i, *j;
@@ -462,6 +465,7 @@ DEFUN (show_ipv6_ospf6_database_router,
        "Specify Advertising Router as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 6;
   int level;
   struct listnode *i, *j;
@@ -598,6 +602,7 @@ DEFUN (show_ipv6_ospf6_database_type_id,
        "Specify Link state ID as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   int level;
   struct listnode *i, *j;
@@ -754,6 +759,7 @@ DEFUN (show_ipv6_ospf6_database_type_router,
        "Specify Advertising Router as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   int level;
   struct listnode *i, *j;
@@ -848,6 +854,7 @@ DEFUN (show_ipv6_ospf6_database_id_router,
        "Specify Advertising Router as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 5;
   int level;
   struct listnode *i, *j;
@@ -935,6 +942,7 @@ DEFUN (show_ipv6_ospf6_database_adv_router_linkstate_id,
        "Specify Link state ID as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_ipv4 = 5;
   int level;
   struct listnode *i, *j;
@@ -1037,6 +1045,7 @@ DEFUN (show_ipv6_ospf6_database_type_id_router,
        "Specify Advertising Router as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   int level;
   struct listnode *i, *j;
@@ -1162,6 +1171,7 @@ DEFUN (show_ipv6_ospf6_database_type_adv_router_linkstate_id,
        "Specify Link state ID as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   int level;
   struct listnode *i, *j;
@@ -1259,6 +1269,7 @@ DEFUN (show_ipv6_ospf6_database_self_originated,
        "Display Self-originated LSAs\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int level;
   struct listnode *i, *j;
   struct ospf6 *o = ospf6;
@@ -1341,6 +1352,7 @@ DEFUN (show_ipv6_ospf6_database_type_self_originated,
        "Display Self-originated LSAs\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int level;
   struct listnode *i, *j;
   struct ospf6 *o = ospf6;
@@ -1444,6 +1456,7 @@ DEFUN (show_ipv6_ospf6_database_type_self_originated_linkstate_id,
        "Specify Link state ID as IPv4 address notation\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   int level;
   struct listnode *i, *j;
@@ -1558,6 +1571,7 @@ DEFUN (show_ipv6_ospf6_database_type_id_self_originated,
        "Display Self-originated LSAs\n"
       )
 {
+  /* CHECK ME argc referenced below */
   int idx_lsa = 4;
   int level;
   struct listnode *i, *j;
@@ -1646,6 +1660,7 @@ DEFUN (show_ipv6_ospf6_border_routers,
        "Display routing table for ABR and ASBR\n"
       )
 {
+  /* CHECK ME argc referenced below */
   u_int32_t adv_router;
   void (*showfunc) (struct vty *, struct ospf6_route *);
   struct ospf6_route *ro;
@@ -1724,6 +1739,7 @@ DEFUN (show_ipv6_ospf6_linkstate,
        "Display linkstate routing table\n"
       )
 {
+  /* CHECK ME argc referenced below */
   struct listnode *node;
   struct ospf6_area *oa;
 
@@ -1751,6 +1767,7 @@ DEFUN (show_ipv6_ospf6_linkstate_detail,
        "Display linkstate routing table\n"
       )
 {
+  /* CHECK ME argc referenced below */
   struct listnode *node;
   struct ospf6_area *oa;