diff options
| author | Igor Ryzhov <iryzhov@nfware.com> | 2021-10-06 21:06:23 +0200 |
|---|---|---|
| committer | Igor Ryzhov <iryzhov@nfware.com> | 2021-10-20 19:07:15 +0200 |
| commit | ee1455dd983e2b19018890c2da5e22bb97b3adb7 (patch) | |
| tree | 2ad4cece5e23cd14e95073f5d35549d61b3e0b8b /ospfd/ospf_lsa.c | |
| parent | Merge pull request #9811 from donaldsharp/rib_update_fix (diff) | |
| download | frr-ee1455dd983e2b19018890c2da5e22bb97b3adb7.tar.xz frr-ee1455dd983e2b19018890c2da5e22bb97b3adb7.zip | |
lib: change thread_add_* API
Do not return pointer to the newly created thread from various thread_add
functions. This should prevent developers from storing a thread pointer
into some variable without letting the lib know that the pointer is
stored. When the lib doesn't know that the pointer is stored, it doesn't
prevent rescheduling and it can lead to hard to find bugs. If someone
wants to store the pointer, they should pass a double pointer as the last
argument.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Diffstat (limited to 'ospfd/ospf_lsa.c')
| -rw-r--r-- | ospfd/ospf_lsa.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c index cc1b2919c..10541b09b 100644 --- a/ospfd/ospf_lsa.c +++ b/ospfd/ospf_lsa.c @@ -2480,10 +2480,6 @@ ospf_router_lsa_install(struct ospf *ospf, struct ospf_lsa *new, int rt_recalc) return new; } -#define OSPF_INTERFACE_TIMER_ON(T, F, V) \ - if (!(T)) \ - (T) = thread_add_timer(master, (F), oi, (V)) - /* Install network-LSA to an area. */ static struct ospf_lsa *ospf_network_lsa_install(struct ospf *ospf, struct ospf_interface *oi, |