diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2018-08-20 20:05:53 +0200 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2018-09-06 22:50:58 +0200 |
| commit | 266469ebababa2d6949bbd22390010d422a68356 (patch) | |
| tree | a5b15fdf7d24d393645d2e898350a87a5b59f9d8 /ospfd/ospf_ri.c | |
| parent | lib: Modify zlog_warn to vty_out (diff) | |
| download | frr-266469ebababa2d6949bbd22390010d422a68356.tar.xz frr-266469ebababa2d6949bbd22390010d422a68356.zip | |
ospfd: Cleanup some warnings that were not warnings
1) stream allocation cannot fail
2) some warnings were removed when functions safely ignored
the calling parameters being wrong.
3) some warnings were removed when functions did not consider
the state as an error since we did not return an error code.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'ospfd/ospf_ri.c')
| -rw-r--r-- | ospfd/ospf_ri.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/ospfd/ospf_ri.c b/ospfd/ospf_ri.c index c9d0a53c8..4f6e1be0f 100644 --- a/ospfd/ospf_ri.c +++ b/ospfd/ospf_ri.c @@ -742,10 +742,8 @@ static struct ospf_lsa *ospf_router_info_lsa_new() uint16_t length; /* Create a stream for LSA. */ - if ((s = stream_new(OSPF_MAX_LSA_SIZE)) == NULL) { - zlog_warn("ospf_router_info_lsa_new: stream_new() ?"); - return NULL; - } + s = stream_new(OSPF_MAX_LSA_SIZE); + lsah = (struct lsa_header *)STREAM_DATA(s); options = OSPF_OPTION_E; /* Enable AS external as we flood RI with |