summaryrefslogtreecommitdiffstats
path: root/ospfd
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@cumulusnetworks.com>2020-08-12 15:49:20 +0200
committerDonald Sharp <sharpd@cumulusnetworks.com>2020-08-12 15:49:20 +0200
commitd142453d6b322de258e123dcde28b2ee9813a289 (patch)
treec7ffca84fc93b65c174e43be670a3d7451c49c3d /ospfd
parentlib: Fixup comment indentations in thread.c (diff)
downloadfrr-d142453d6b322de258e123dcde28b2ee9813a289.tar.xz
frr-d142453d6b322de258e123dcde28b2ee9813a289.zip
lib: Properly handle POLLERR from poll()
There are situations where POLLERR will be returned. But since we were not handling it. Thread processing effectively is turned into an infinite loop, which is bad. Modify the code so that if we receive a POLLERR we turn it into a read event to be handled as an error from the handler function. This was discovered in pim: Thread statistics for pimd: Showing poll FD's for main -------------------------- Count: 14/1024 0 fd: 9 events: 1 revents: 0 mroute_read 1 fd: 12 events: 1 revents: 0 vty_accept 2 fd: 13 events: 1 revents: 0 vtysh_accept 3 fd: 11 events: 1 revents: 0 zclient_read 4 fd: 15 events: 1 revents: 0 mroute_read 5 fd: 16 events: 1 revents: 0 mroute_read 6 fd: 17 events: 1 revents: 0 pim_sock_read 7 fd: 19 events: 1 revents: 0 pim_sock_read 8 fd: 21 events: 1 revents: 0 pim_igmp_read 9 fd: 22 events: 1 revents: 0 pim_sock_read 10 fd: 23 events: 1 revents: 0 pim_sock_read 11 fd: 20 events: 1 revents: 0 vtysh_read 12 fd: 18 events: 1 revents: 0 pim_sock_read 13 fd: 24 events: 0 revents: 0 strace was showing this line over and over and over: poll([{fd=9, events=POLLIN}, {fd=12, events=POLLIN}, {fd=13, events=POLLIN}, {fd=11, events=POLLIN}, {fd=15, events=POLLIN}, {fd=16, events=POLLIN}, {fd=17, events=POLLIN}, {fd=19, events=POLLIN}, {fd=21, events=POLLIN}, {fd=22, events=POLLIN}, {fd=23, events=POLLIN}, {fd=20, events=POLLIN}, {fd=18, events=POLLIN}, {fd=6, events=POLLIN}], 14, 20) = 1 ([{fd=21, revents=POLLERR}]) Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'ospfd')
0 files changed, 0 insertions, 0 deletions