summaryrefslogtreecommitdiffstats
path: root/pbrd/pbr_nht.c
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@cumulusnetworks.com>2019-09-24 14:20:34 +0200
committerDonald Sharp <sharpd@cumulusnetworks.com>2019-09-24 14:20:34 +0200
commit4550d5df00c64554fe21d490ec4cd7d0845111c2 (patch)
treed77b9270ae572d6a65c3c32256fd9a4f3f66243d /pbrd/pbr_nht.c
parentMerge pull request #5039 from opensourcerouting/isisd-yang-state-data (diff)
downloadfrr-4550d5df00c64554fe21d490ec4cd7d0845111c2.tar.xz
frr-4550d5df00c64554fe21d490ec4cd7d0845111c2.zip
pbrd: We should be looking for v4 and v6 nexthop types
The code should be looking for both v4 and v6 nexthop types instead of v4 nexthop types 2 times. Found by Coverity SA Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'pbrd/pbr_nht.c')
-rw-r--r--pbrd/pbr_nht.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/pbrd/pbr_nht.c b/pbrd/pbr_nht.c
index 359f869c4..ae04402f4 100644
--- a/pbrd/pbr_nht.c
+++ b/pbrd/pbr_nht.c
@@ -711,7 +711,7 @@ pbr_nht_individual_nexthop_gw_update(struct pbr_nexthop_cache *pnhc,
}
if (pnhc->nexthop->type == NEXTHOP_TYPE_IPV4_IFINDEX
- || pnhc->nexthop->type == NEXTHOP_TYPE_IPV4_IFINDEX) {
+ || pnhc->nexthop->type == NEXTHOP_TYPE_IPV6_IFINDEX) {
/* GATEWAY_IFINDEX type shouldn't resolve to group */
if (pnhi->nhr->nexthop_num > 1) {