summaryrefslogtreecommitdiffstats
path: root/pimd/pim_mroute.c
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@cumulusnetworks.com>2019-06-14 02:03:08 +0200
committerDonald Sharp <sharpd@cumulusnetworks.com>2019-06-20 01:13:10 +0200
commit9e132a491a82c5d4d23e080ffb4c124ac3c6f6dc (patch)
treeec1f8db9058fa2a9daf0a3fe1c400c85b9afb856 /pimd/pim_mroute.c
parentpimd: ALLOC functions cannot fail. (diff)
downloadfrr-9e132a491a82c5d4d23e080ffb4c124ac3c6f6dc.tar.xz
frr-9e132a491a82c5d4d23e080ffb4c124ac3c6f6dc.zip
pimd: Ensure channel_oil_add is created through all paths
If we create a channel_oil ensure that all paths that we can go down will create one. Future commits can remove the (up->channel_oil) tests. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'pimd/pim_mroute.c')
-rw-r--r--pimd/pim_mroute.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/pimd/pim_mroute.c b/pimd/pim_mroute.c
index d0cd27008..b1c55c1f4 100644
--- a/pimd/pim_mroute.c
+++ b/pimd/pim_mroute.c
@@ -201,6 +201,10 @@ static int pim_mroute_msg_nocache(int fd, struct interface *ifp,
* Let's blackhole those packets for the moment
* As that they will be coming up to the cpu
* and causing us to consider them.
+ *
+ * This *will* create a dangling channel_oil
+ * that I see no way to get rid of. Just noting
+ * this for future reference.
*/
c_oil = pim_channel_oil_add(pim_ifp->pim, &sg,
pim_ifp->mroute_vif_index,