diff options
author | Sarita Patra <saritap@vmware.com> | 2019-03-19 04:22:04 +0100 |
---|---|---|
committer | Sarita Patra <saritap@vmware.com> | 2019-03-19 04:22:04 +0100 |
commit | 47e3ce59c434dbde996373268896c595ba8a6bf4 (patch) | |
tree | dc27cdf77ad9ce062cb85242baed81e887a5dc03 /pimd/pim_oil.c | |
parent | pimd: Handling delete nexthop track for PIM upstream address (diff) | |
download | frr-47e3ce59c434dbde996373268896c595ba8a6bf4.tar.xz frr-47e3ce59c434dbde996373268896c595ba8a6bf4.zip |
pimd: Addressing the review comments
Signed-off-by: Sarita Patra <saritap@vmware.com>
Diffstat (limited to 'pimd/pim_oil.c')
-rw-r--r-- | pimd/pim_oil.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/pimd/pim_oil.c b/pimd/pim_oil.c index 35801aa49..55d26113f 100644 --- a/pimd/pim_oil.c +++ b/pimd/pim_oil.c @@ -190,10 +190,6 @@ struct channel_oil *pim_channel_oil_add(struct pim_instance *pim, c_oil->installed = 0; c_oil->up = pim_upstream_find(pim, sg); c_oil->pim = pim; - if (input_vif_index != MAXVIFS) - c_oil->is_valid = 1; - else - c_oil->is_valid = 0; listnode_add_sort(pim->channel_oil_list, c_oil); @@ -453,10 +449,10 @@ int pim_channel_add_oif(struct channel_oil *channel_oil, struct interface *oif, channel_oil->oil.mfcc_ttls[pim_ifp->mroute_vif_index] = PIM_MROUTE_MIN_TTL; - /* channel_oil->is_valid indicate if this entry is valid to get - * installed in kernel. + /* channel_oil->oil.mfcc_parent != MAXVIFS indicate this entry is not + * valid to get installed in kernel. */ - if (channel_oil->is_valid) { + if (channel_oil->oil.mfcc_parent != MAXVIFS) { if (pim_mroute_add(channel_oil, __PRETTY_FUNCTION__)) { if (PIM_DEBUG_MROUTE) { char group_str[INET_ADDRSTRLEN]; |