diff options
| author | Donald Sharp <sharpd@nvidia.com> | 2021-05-12 20:31:45 +0200 |
|---|---|---|
| committer | Donald Sharp <sharpd@nvidia.com> | 2021-05-12 20:36:59 +0200 |
| commit | d3cc1e45182196a0b9b7146bcbaef04f346d9721 (patch) | |
| tree | 2841feca90eae72f58a1c0c3e23af860db3f3b46 /pimd/pim_pim.c | |
| parent | pimd: There exists a path where on vrf bringup we do not create the pimreg (diff) | |
| download | frr-d3cc1e45182196a0b9b7146bcbaef04f346d9721.tar.xz frr-d3cc1e45182196a0b9b7146bcbaef04f346d9721.zip | |
pimd: Remove pim->vrf_id and use pim->vrf->vrf_id
VRF creation can happen from either cli or from
knowledged about the vrf learned from zebra.
In the case where we learn about the vrf from
the cli, the vrf id is UNKNOWN. Upon actual
creation of the vrf, lib/vrf.c touches up the vrf_id
and calls pim_vrf_enable to turn it on properly.
At this point in time we have a pim->vrf_id of
UNKNOWN and the vrf->vrf_id of the right value.
There is no point in duplicating this data. So just
remove all pim->vrf_id and use the vrf->vrf_id instead
since we keep a copy of the pim->vrf pointer.
This will remove some crashes where we expect the
pim->vrf_id to be usable and it's not.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'pimd/pim_pim.c')
| -rw-r--r-- | pimd/pim_pim.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pimd/pim_pim.c b/pimd/pim_pim.c index 4ba08a19d..e7ac0d4e5 100644 --- a/pimd/pim_pim.c +++ b/pimd/pim_pim.c @@ -369,7 +369,7 @@ static int pim_sock_read(struct thread *t) * the right ifindex, so just use it. We know * it's the right interface because we bind to it */ - ifp = if_lookup_by_index(ifindex, pim_ifp->pim->vrf_id); + ifp = if_lookup_by_index(ifindex, pim_ifp->pim->vrf->vrf_id); if (!ifp || !ifp->info) { if (PIM_DEBUG_PIM_PACKETS) zlog_debug( |