*: remove --enable-tcp-zebra, rework ZAPI path

This adds "@tcp" as new choice on the -z option present in zebra and the
protocol daemons.  The --enable-tcp-zebra option on configure is no
longer needed, both UNIX and TCP socket support is always available.

Note that @tcp should not be used by default (e.g. in an init script),
and --enable-tcp-zebra should never have been in any distro package
builds, because

**** TCP-ZEBRA IS A SECURITY PROBLEM ****

It allows arbitrary local users to mess with the routing table and
inject bogus data -- and also ZAPI is not designed to be robust against
attacks.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

1 files changed, 0 insertions, 10 deletions

diff --git a/redhat/frr.spec.in b/redhat/frr.spec.in
index b23249e04..12cdcf04f 100644
--- a/redhat/frr.spec.in
+++ b/redhat/frr.spec.in
@@ -10,7 +10,6 @@
 
 #################### FRRouting (FRR) configure options #####################
 # with-feature options
-%{!?with_tcp_zebra:     %global  with_tcp_zebra     0 }
 %{!?with_pam:           %global  with_pam           0 }
 %{!?with_ospfclient:    %global  with_ospfclient    1 }
 %{!?with_ospfapi:       %global  with_ospfapi       1 }
@@ -75,12 +74,6 @@
     %global  with_pimd  0
 %endif
 
-# if FPM is enabled, then enable tcp_zebra as well 
-#
-%if %{with_fpm}
-    %global with_tcp_zebra  1
-%endif
-
 # misc internal defines
 %{!?frr_uid:            %global  frr_uid            92 }
 %{!?frr_gid:            %global  frr_gid            92 }
@@ -234,9 +227,6 @@ developing OSPF-API and frr applications.
 %if %{with_multipath}
     --enable-multipath=%{with_multipath} \
 %endif
-%if %{with_tcp_zebra}
-    --enable-tcp-zebra \
-%endif
     --enable-vtysh \
 %if %{with_ospfclient}
     --enable-ospfclient \