diff options
| author | Paul Jakma <paul.jakma@sun.com> | 2006-09-11 04:14:16 +0200 |
|---|---|---|
| committer | Paul Jakma <paul.jakma@sun.com> | 2006-09-11 04:14:16 +0200 |
| commit | b25ea4d085c858137ec28b1be9d6ab6c30a97303 (patch) | |
| tree | 476bf1799357a70ea42cdfccee9340e8b32172d6 /ripd/rip_routemap.c | |
| parent | [ripd] bug #278: remove gratuitous use of mid-function declaration (diff) | |
| download | frr-b25ea4d085c858137ec28b1be9d6ab6c30a97303.tar.xz frr-b25ea4d085c858137ec28b1be9d6ab6c30a97303.zip | |
[ripd] bug #293: routemap set metric doesn't check for underflow correctly
2006-09-11 Paul Jakma <paul.jakma@sun.com>
* rip_routemap.c: (route_set_metric) underflow check needs to
use signed, problem identified and diagnosed by Pavel
Nikiforov in bug #293.
Diffstat (limited to '')
| -rw-r--r-- | ripd/rip_routemap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ripd/rip_routemap.c b/ripd/rip_routemap.c index 9d6fd16e5..cb87ea555 100644 --- a/ripd/rip_routemap.c +++ b/ripd/rip_routemap.c @@ -530,7 +530,7 @@ route_set_metric (void *rule, struct prefix *prefix, else if (mod->type == metric_absolute) rinfo->metric_out = mod->metric; - if (rinfo->metric_out < 1) + if ((signed int)rinfo->metric_out < 1) rinfo->metric_out = 1; if (rinfo->metric_out > RIP_METRIC_INFINITY) rinfo->metric_out = RIP_METRIC_INFINITY; |