summaryrefslogtreecommitdiffstats
path: root/ripd/subdir.am
diff options
context:
space:
mode:
authorDavid Lamparter <equinox@opensourcerouting.org>2021-07-21 11:04:23 +0200
committerDavid Lamparter <equinox@opensourcerouting.org>2021-07-21 17:10:08 +0200
commit63116a7008706988136785ffa011cefee0355193 (patch)
treebb9cd12975d5560d4c3df5d2c9e5d0e32cea33cf /ripd/subdir.am
parentMerge pull request #8956 from pguibert6WIND/bgp_loop_through_itself (diff)
downloadfrr-63116a7008706988136785ffa011cefee0355193.tar.xz
frr-63116a7008706988136785ffa011cefee0355193.zip
build: fix `AM_LDFLAGS` usage (and gcov)
like the other automake variables, setting `xyz_LDFLAGS` causes `AM_LDFLAGS` to be ignored for `xyz`. For some reason I had in my mind that automake doesn't do this for LDFLAGS, but... it does. (Which is consistent with `_CFLAGS` and co.) So, all the libraries and modules have been ignoring `AM_LDFLAGS` (which includes `SAN_FLAGS` too). Set up new `LIB_LDFLAGS` and `MODULE_LDFLAGS` to handle all of this correctly (and move these bits to a central location.) Fixes: #9034 Fixes: 0c4285d77eb ("build: properly split CFLAGS from AC_CFLAGS") Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Diffstat (limited to 'ripd/subdir.am')
-rw-r--r--ripd/subdir.am2
1 files changed, 1 insertions, 1 deletions
diff --git a/ripd/subdir.am b/ripd/subdir.am
index 8de0fc4b5..b43e369ab 100644
--- a/ripd/subdir.am
+++ b/ripd/subdir.am
@@ -57,5 +57,5 @@ nodist_ripd_ripd_SOURCES = \
ripd_ripd_snmp_la_SOURCES = ripd/rip_snmp.c
ripd_ripd_snmp_la_CFLAGS = $(AM_CFLAGS) $(SNMP_CFLAGS) -std=gnu11
-ripd_ripd_snmp_la_LDFLAGS = -avoid-version -module -shared -export-dynamic
+ripd_ripd_snmp_la_LDFLAGS = $(MODULE_LDFLAGS)
ripd_ripd_snmp_la_LIBADD = lib/libfrrsnmp.la