diff options
| author | Daniel Walton <dwalton@cumulusnetworks.com> | 2016-09-29 19:48:57 +0200 |
|---|---|---|
| committer | Daniel Walton <dwalton@cumulusnetworks.com> | 2016-09-29 19:48:57 +0200 |
| commit | 67656e9b65ab7c6bb979be72b4917cfd4a2241b6 (patch) | |
| tree | 823937fe0aded2bcfad54dfdea570259bd4820ac /ripd | |
| parent | ospfd: minor parser fixes (diff) | |
| download | frr-67656e9b65ab7c6bb979be72b4917cfd4a2241b6.tar.xz frr-67656e9b65ab7c6bb979be72b4917cfd4a2241b6.zip | |
all: added CHECK ME for DEFUNs that look at argc
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Diffstat (limited to 'ripd')
| -rw-r--r-- | ripd/rip_interface.c | 1 | ||||
| -rw-r--r-- | ripd/rip_routemap.c | 9 |
2 files changed, 10 insertions, 0 deletions
diff --git a/ripd/rip_interface.c b/ripd/rip_interface.c index d6686399c..6b2fef7f5 100644 --- a/ripd/rip_interface.c +++ b/ripd/rip_interface.c @@ -1528,6 +1528,7 @@ DEFUN (ip_rip_authentication_mode, "RFC compatible\n" "Old ripd compatible\n") { + /* CHECK ME argc referenced below */ char *cryptmode = argv[4]->text; char *authlen = (argc > 5) ? argv[6]->text : NULL; struct interface *ifp; diff --git a/ripd/rip_routemap.c b/ripd/rip_routemap.c index e1017cfb2..e43c398c4 100644 --- a/ripd/rip_routemap.c +++ b/ripd/rip_routemap.c @@ -754,6 +754,7 @@ DEFUN (no_match_metric, "Match metric of route\n" "Metric value\n") { + /* CHECK ME argc referenced below */ char *mval = (argc == 4) ? argv[3]->arg : NULL; return rip_route_match_delete (vty, vty->index, "metric", mval); } @@ -778,6 +779,7 @@ DEFUN (no_match_interface, "Match first hop interface of route\n" "Interface name\n") { + /* CHECK ME argc referenced below */ char *iface = (argc == 4) ? argv[3]->arg : NULL; return rip_route_match_delete (vty, vty->index, "interface", iface); } @@ -807,6 +809,7 @@ DEFUN (no_match_ip_next_hop, "IP access-list number (expanded range)\n" "IP Access-list name\n") { + /* CHECK ME argc referenced below */ char *al = (argc == 5) ? argv[4]->arg : NULL; return rip_route_match_delete (vty, vty->index, "ip next-hop", al); } @@ -834,6 +837,7 @@ DEFUN (no_match_ip_next_hop_prefix_list, "Match entries of prefix-lists\n" "IP prefix-list name\n") { + /* CHECK ME argc referenced below */ char *plist = (argc == 6) ? argv[5]->arg : NULL; return rip_route_match_delete (vty, vty->index, "ip next-hop prefix-list", plist); } @@ -865,6 +869,7 @@ DEFUN (no_match_ip_address, "IP access-list number (expanded range)\n" "IP Access-list name\n") { + /* CHECK ME argc referenced below */ char *al = (argc == 5) ? argv[4]->arg : NULL; return rip_route_match_delete (vty, vty->index, "ip address", al); } @@ -893,6 +898,7 @@ DEFUN (no_match_ip_address_prefix_list, "Match entries of prefix-lists\n" "IP prefix-list name\n") { + /* CHECK ME argc referenced below */ char *plist = (argc == 6) ? argv[5]->arg : NULL; return rip_route_match_delete (vty, vty->index, "ip address prefix-list", plist); } @@ -917,6 +923,7 @@ DEFUN (no_match_tag, "Match tag of route\n" "Metric value\n") { + /* CHECK ME argc referenced below */ char *mval = (argc == 4) ? argv[3]->arg : NULL; return rip_route_match_delete (vty, vty->index, "tag", mval); } @@ -989,6 +996,7 @@ DEFUN (no_set_ip_nexthop, "Next hop address\n" "IP address of next hop\n") { + /* CHECK ME argc referenced below */ char *addr = (argc == 5) ? argv[4]->arg : NULL; return rip_route_set_delete (vty, vty->index, "ip next-hop", addr); } @@ -1013,6 +1021,7 @@ DEFUN (no_set_tag, "Tag value for routing protocol\n" "Tag value\n") { + /* CHECK ME argc referenced below */ char *tag = (argc == 4) ? argv[3]->arg : NULL; return rip_route_set_delete (vty, vty->index, "tag", tag); } |