summaryrefslogtreecommitdiffstats
path: root/ripngd
diff options
context:
space:
mode:
authorQuentin Young <qlyoung@users.noreply.github.com>2020-03-05 23:38:13 +0100
committerGitHub <noreply@github.com>2020-03-05 23:38:13 +0100
commit5d2724ec2564b648bf93dc7b164a1398cde3c214 (patch)
tree92976c12468fcce1c582152d059e4bb4b0514e5d /ripngd
parentMerge pull request #5918 from ton31337/fix/__func__everywhere (diff)
parent*: use gmtime_r, localtime_r exclusively (diff)
downloadfrr-5d2724ec2564b648bf93dc7b164a1398cde3c214.tar.xz
frr-5d2724ec2564b648bf93dc7b164a1398cde3c214.zip
Merge pull request #5916 from mjstapp/fix_gmtime
*: use gmtime_r exclusively
Diffstat (limited to 'ripngd')
-rw-r--r--ripngd/ripng_peer.c16
-rw-r--r--ripngd/ripngd.c10
2 files changed, 13 insertions, 13 deletions
diff --git a/ripngd/ripng_peer.c b/ripngd/ripng_peer.c
index 109524e21..c038bfccf 100644
--- a/ripngd/ripng_peer.c
+++ b/ripngd/ripng_peer.c
@@ -141,7 +141,7 @@ void ripng_peer_bad_packet(struct ripng *ripng, struct sockaddr_in6 *from)
static char *ripng_peer_uptime(struct ripng_peer *peer, char *buf, size_t len)
{
time_t uptime;
- struct tm *tm;
+ struct tm tm;
/* If there is no connection has been done before print `never'. */
if (peer->uptime == 0) {
@@ -152,17 +152,17 @@ static char *ripng_peer_uptime(struct ripng_peer *peer, char *buf, size_t len)
/* Get current time. */
uptime = time(NULL);
uptime -= peer->uptime;
- tm = gmtime(&uptime);
+ gmtime_r(&uptime, &tm);
if (uptime < ONE_DAY_SECOND)
- snprintf(buf, len, "%02d:%02d:%02d", tm->tm_hour, tm->tm_min,
- tm->tm_sec);
+ snprintf(buf, len, "%02d:%02d:%02d", tm.tm_hour, tm.tm_min,
+ tm.tm_sec);
else if (uptime < ONE_WEEK_SECOND)
- snprintf(buf, len, "%dd%02dh%02dm", tm->tm_yday, tm->tm_hour,
- tm->tm_min);
+ snprintf(buf, len, "%dd%02dh%02dm", tm.tm_yday, tm.tm_hour,
+ tm.tm_min);
else
- snprintf(buf, len, "%02dw%dd%02dh", tm->tm_yday / 7,
- tm->tm_yday - ((tm->tm_yday / 7) * 7), tm->tm_hour);
+ snprintf(buf, len, "%02dw%dd%02dh", tm.tm_yday / 7,
+ tm.tm_yday - ((tm.tm_yday / 7) * 7), tm.tm_hour);
return buf;
}
diff --git a/ripngd/ripngd.c b/ripngd/ripngd.c
index f8d7dc968..b583df4de 100644
--- a/ripngd/ripngd.c
+++ b/ripngd/ripngd.c
@@ -1991,20 +1991,20 @@ void ripng_event(struct ripng *ripng, enum ripng_event event, int sock)
static void ripng_vty_out_uptime(struct vty *vty, struct ripng_info *rinfo)
{
time_t clock;
- struct tm *tm;
+ struct tm tm;
#define TIME_BUF 25
char timebuf[TIME_BUF];
struct thread *thread;
if ((thread = rinfo->t_timeout) != NULL) {
clock = thread_timer_remain_second(thread);
- tm = gmtime(&clock);
- strftime(timebuf, TIME_BUF, "%M:%S", tm);
+ gmtime_r(&clock, &tm);
+ strftime(timebuf, TIME_BUF, "%M:%S", &tm);
vty_out(vty, "%5s", timebuf);
} else if ((thread = rinfo->t_garbage_collect) != NULL) {
clock = thread_timer_remain_second(thread);
- tm = gmtime(&clock);
- strftime(timebuf, TIME_BUF, "%M:%S", tm);
+ gmtime_r(&clock, &tm);
+ strftime(timebuf, TIME_BUF, "%M:%S", &tm);
vty_out(vty, "%5s", timebuf);
}
}