summaryrefslogtreecommitdiffstats
path: root/vtysh
diff options
context:
space:
mode:
authorDaniel Walton <dwalton@cumulusnetworks.com>2016-10-06 21:56:13 +0200
committerDaniel Walton <dwalton@cumulusnetworks.com>2016-10-06 21:56:13 +0200
commit82f97584fbc708f4089b1b4f7e6fdc7e07b2db4e (patch)
tree2e3540ca88b53f855e03bd4a4e3b1c63d732e5e5 /vtysh
parentlib: Log invalid/unknown commands to log file (diff)
downloadfrr-82f97584fbc708f4089b1b4f7e6fdc7e07b2db4e.tar.xz
frr-82f97584fbc708f4089b1b4f7e6fdc7e07b2db4e.zip
all: removed all DEFUN command stomps
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'vtysh')
-rwxr-xr-xvtysh/extract.pl.in12
1 files changed, 2 insertions, 10 deletions
diff --git a/vtysh/extract.pl.in b/vtysh/extract.pl.in
index 5c8e6a4d2..bcebe2cc4 100755
--- a/vtysh/extract.pl.in
+++ b/vtysh/extract.pl.in
@@ -212,11 +212,6 @@ foreach (@ARGV) {
}
}
-my $bad_cli_stomps = 71;
-# Currently we have $bad_cli_stomps. This was determined by
-# running this script and counting up the collisions from what
-# was returned.
-#
# When we have cli commands that map to the same function name, we
# can introduce subtle bugs due to code not being called when
# we think it is.
@@ -224,12 +219,9 @@ my $bad_cli_stomps = 71;
# If extract.pl fails with a error message and you've been
# modifying the cli, then go back and fix your code to
# not have cli command function collisions.
-#
-# If you've removed a cli overwrite, you can safely subtract
-# one from $bad_cli_stomps. If you've added to the problem
# please fix your code before submittal
-if ($cli_stomp != $bad_cli_stomps) {
- warn "Expected $bad_cli_stomps command line stomps, but got $cli_stomp instead\n";
+if ($cli_stomp) {
+ warn "There are $cli_stomp command line stomps\n";
exit $cli_stomp;
}