diff options
author | Donald Sharp <sharpd@nvidia.com> | 2021-06-24 18:23:33 +0200 |
---|---|---|
committer | Donald Sharp <sharpd@nvidia.com> | 2022-02-07 22:10:03 +0100 |
commit | c6eee91f66956a14d73f6b2f2e43a792c854195a (patch) | |
tree | b4888f423738147f30ac134df048766fdda1dfb3 /zebra/redistribute.c | |
parent | Merge pull request #10518 from donaldsharp/af_unspec (diff) | |
download | frr-c6eee91f66956a14d73f6b2f2e43a792c854195a.tar.xz frr-c6eee91f66956a14d73f6b2f2e43a792c854195a.zip |
zebra: Fix ships in the night issue
When using wait for install there exists situations where
zebra will issue several route change operations to the kernel
but end up in a state where we shouldn't be at the end
due to extra data being received. Example:
a) zebra receives from bgp a route change, installs sends the
route to the kernel.
b) zebra receives a route deletion from bgp, removes the
struct route entry and then sends to the kernel a deletion.
c) zebra receives an asynchronous notification that (a) succeeded
but we treat this as a new route.
This is the ships in the night problem. In this case if we receive
notification from the kernel about a route that we know nothing
about and we are not in startup and we are doing asic offload
then we can ignore this update.
Ticket: #2563300
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'zebra/redistribute.c')
-rw-r--r-- | zebra/redistribute.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/zebra/redistribute.c b/zebra/redistribute.c index fdd2c8405..1a28f8cee 100644 --- a/zebra/redistribute.c +++ b/zebra/redistribute.c @@ -698,7 +698,7 @@ int zebra_add_import_table_entry(struct zebra_vrf *zvrf, struct route_node *rn, ng = nexthop_group_new(); copy_nexthops(&ng->nexthop, re->nhe->nhg.nexthop, NULL); - rib_add_multipath(afi, SAFI_UNICAST, &p, NULL, newre, ng); + rib_add_multipath(afi, SAFI_UNICAST, &p, NULL, newre, ng, false); return 0; } |