zebra: fix race condition in i/o pthread shutdown

I mistakenly used an external mechanism to cause a pthread to shut
itself down instead of using the one built into frr_pthread.[ch]. This
created a race condition whereby a pthread could schedule work onto a
dead pthread and cause it to reanimate.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

1 files changed, 0 insertions, 3 deletions

diff --git a/zebra/zserv.h b/zebra/zserv.h
index 2a681552d..78cc200fa 100644
--- a/zebra/zserv.h
+++ b/zebra/zserv.h
@@ -53,9 +53,6 @@ struct zserv {
 	/* Client pthread */
 	struct frr_pthread *pthread;
 
-	/* Whether the thread is waiting to be killed */
-	_Atomic bool dead;
-
 	/* Client file descriptor. */
 	int sock;