diff options
| author | Chirag Shah <chirag@nvidia.com> | 2021-05-05 03:09:37 +0200 |
|---|---|---|
| committer | Chirag Shah <chirag@nvidia.com> | 2021-05-08 00:02:05 +0200 |
| commit | 196d7a86d065b388d0b14e16755a2383da4b5428 (patch) | |
| tree | ba4fcc222b4429f9c6e344714ac7e68105158678 /zebra | |
| parent | Merge pull request #8634 from idryzhov/ospf-vrf-redist (diff) | |
| download | frr-196d7a86d065b388d0b14e16755a2383da4b5428.tar.xz frr-196d7a86d065b388d0b14e16755a2383da4b5428.zip | |
zebra: check vni oper state in svi up notif
When clagd is stopped on secondary device,
all vxlan interfaces (vnis) are kept in protodown state.
FRR treats protodown vxlan interfaces (vnis) as interface down
and sends vni delete to bgpd.
In the event of clagd down, SVIs are flapping as underlying
bridge is going through churn.
When FRR receives SVI up notification do not trigger event to bgpd
if vnis are operationaly down.
Ticket:#2600210 CM-22929
Reviewed By:CCR-11544
Testing Done:
Performed CLAG stop/start on secondary device, all vxlan devices
remained in protodown along with this validated the vnis are cleaned up
and added back in bgpd.
Signed-off-by: Chirag Shah <chirag@nvidia.com>
Diffstat (limited to 'zebra')
| -rw-r--r-- | zebra/zebra_vxlan.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/zebra/zebra_vxlan.c b/zebra/zebra_vxlan.c index 3ac7ee8f4..23aeb7190 100644 --- a/zebra/zebra_vxlan.c +++ b/zebra/zebra_vxlan.c @@ -4530,7 +4530,8 @@ int zebra_vxlan_svi_down(struct interface *ifp, struct interface *link_if) zevpn->vrf_id = VRF_DEFAULT; /* update the tenant vrf in BGP */ - zebra_evpn_send_add_to_client(zevpn); + if (if_is_operative(zevpn->vxlan_if)) + zebra_evpn_send_add_to_client(zevpn); } } return 0; @@ -4582,7 +4583,9 @@ int zebra_vxlan_svi_up(struct interface *ifp, struct interface *link_if) /* update the vrf information for l2-vni and inform bgp */ zevpn->vrf_id = ifp->vrf_id; - zebra_evpn_send_add_to_client(zevpn); + + if (if_is_operative(zevpn->vxlan_if)) + zebra_evpn_send_add_to_client(zevpn); /* Install any remote neighbors for this VNI. */ memset(&n_wctx, 0, sizeof(struct neigh_walk_ctx)); |