summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #17542 from ↵HEADmasterRuss White25 hours4-1/+43
|\ | | | | | | | | opensourcerouting/fix/peer-group_remote_as_regression bgpd: Fix remote-as with peer-group
| * tests: Check if remote-as is not flushed once peer-group appliedDonatas Abraitis3 days3-1/+42
| | | | | | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
| * bgpd: Initialize as_type for peer-group as AS_UNSPECIFIEDDonatas Abraitis3 days1-0/+1
| | | | | | | | | | | | | | | | | | Previously AS_UNSPECIFIED was treated as 0, but with now it's 1 after renumbering peer_asn_type enum. Fixes: 0dfe25697f5299326046fcfb66f2c6beca7c423c ("bgpd: Implement neighbor X remote-as auto") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | Merge pull request #17528 from opensourcerouting/fix/peer_notify_copy_errorRuss White25 hours1-1/+1
|\ \ | | | | | | bgpd: Use peer group's member for BGP notify instead of the peer-group
| * | bgpd: Use peer group's member for BGP notify instead of the peer-groupDonatas Abraitis7 days1-1/+1
| | | | | | | | | | | | | | | | | | Fixes: eacf923b00c019e9a877c9716e5d6506594d532e ("bgpd: Fix pattern of usage in bgp_notify_config_change") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | Merge pull request #17547 from donaldsharp/some_cleanupsMark Stapp26 hours66-154/+16
|\ \ \ | | | | | | | | Some cleanups
| * | | tests: bgp_route_server_client should not use /tmpDonald Sharp2 days1-3/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: bgp_snmp_mplsl3vpn should not use /tmp directoryDonald Sharp2 days13-20/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: ospf_metric_propagation do not use /tmpDonald Sharp2 days9-28/+3
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: ospf_multi_instance should not use /tmpDonald Sharp2 days2-6/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: ospf_multi_vrf_bgp_route_leak should not use /tmpDonald Sharp2 days4-8/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: ospf_netns_vrf should not use /tmpDonald Sharp2 days6-12/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: ospf_p2mp should not use /tmpDonald Sharp2 days8-27/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: ospf_prefix_suppression should not use /tmpDonald Sharp2 days3-6/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: pim_autorp should not use /tmpDonald Sharp2 days4-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleanup usage of log file into /tmp. Remove usage of debugs that will slow down test and remove password. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: pim_basic should not use /tmp for outputing of filesDonald Sharp2 days1-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | Use the appropriate log directory. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: simple_snmp_test should not use /tmp for loggingDonald Sharp2 days1-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: pim_cand_rp_bsr uses /tmp directory and it should notDonald Sharp2 days6-12/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: zebra_rib should not use /tmp for log filesDonald Sharp2 days1-2/+1
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: bgp_nexthop_ipv6 remove unused reference to /tmpDonald Sharp2 days1-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This code should not be outputting anything to the /tmp directory, remove commented out code Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: bgp_lu_topo[1|2] should not use log files in /tmpDonald Sharp2 days5-5/+0
| | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | bgpd: bgp_clist.c does not need jhash.hDonald Sharp2 days1-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | It's not used in bgp_clist.c so let's just remove it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | Merge pull request #17306 from pguibert6WIND/bmp_test_factorise_plus_fixRuss White26 hours28-936/+885
|\ \ \ \ | |_|_|/ |/| | | BMP test rework
| * | | topotests: save bgp_bmp json temp files to bmp log folder instead of /tmpPhilippe Guibert46 hours3-9/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Some temporary files are hardwritten in /tmp folder. Use the bmp log folder instead. Replace the bmp log file argument with bmp log folder. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
| * | | tests: save bmp pcap in logdir instead of /tmpLouis Scalbert46 hours3-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | DEBUG_PCAP can be set True to manually enable pcap debugging when running bmp tests. Save bmp pcap in logdir (ie. /tmp/topotests/bgp_bmp.bgp_bmp_X/ instead of /tmp. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com> Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
| * | | tests: fix bmp test parallelizationLouis Scalbert46 hours2-4/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Multiple BMP tests can run in parallel but, when one instance ends, it kills the BMP server process of all BMP tests. Save the PID of a BMP server and only kill it at the end. Link: https://github.com/FRRouting/frr/issues/17465 Fixes: 875511c466 ("topotests: add basic bmp collector") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
| * | | tests: add py extension to bmpserverLouis Scalbert46 hours2-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | to help identify the file type. And apply black. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
| * | | topotests: bgp_bmp, use unified configurationPhilippe Guibert46 hours10-46/+39
| | | | | | | | | | | | | | | | | | | | | | | | Use unified configuration procedure. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
| * | | topotests: fix bmp_collector handling of empty as-pathPhilippe Guibert2 days1-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When configuring the bgp_bmp test with an additional peer that sends empty AS-PATH, the bmp collector is stopping: > [2024-10-28 17:41:51] Finished dissecting data from ('192.0.2.1', 33922) > [2024-10-28 17:41:52] Data received from ('192.0.2.1', 33922): length 195 > [2024-10-28 17:41:52] Got message type: <class 'bmp.BMPRouteMonitoring'> > [2024-10-28 17:41:52] unpack_from requires a buffer of at least 2 bytes for unpacking 2 bytes at offset 0 (actual buffer size is 0) > [2024-10-28 17:41:52] TCP session closed with ('192.0.2.1', 33922) > [2024-10-28 17:41:52] Server shutting down on 192.0.2.10:1789 The parser attempts to read an empty AS-path and considers the length value as a length in bytes, whereas RFC mentions this value as definining the number of AS-PAths. Fix this in the parser. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
| * | | topotests: bmp, create shared library for bmpPhilippe Guibert2 days21-901/+755
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The bgp_bmp and bgp_bmp_vrf tests use similar routines to test the bmp, but are duplicates. Gather the bgp_bmp and the bgp_bmp_vrf tests in a single bgp_bmp folder. - Create a bgpbmp.py library under the bgp_bmp test folder - The bgp_bmp and bgp_bmp_vrf test are renamed to bgp_bmp_1 and bgp_bmp_2 test. - Maintain separate folder for config and output results. Adapt the bgp_bmp library accordingly. - The json output for bgp_bmp_2 test has no referenc to hostame. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | Merge pull request #17525 from famfo/podman-testsDonatas Abraitis5 days2-6/+8
|\ \ \ | | | | | | | | topotests: Allow runing under both docker and podman
| * | | topotests: Allow runing under both docker and podmanfamfo6 days2-6/+8
| | | | | | | | | | | | | | | | Signed-off-by: famfo <famfo@famfo.xyz>
* | | | Merge pull request #16700 from louis-6wind/fix-nhrp-outputDonatas Abraitis6 days1-3/+4
|\ \ \ \ | | | | | | | | | | nhrpd: fix show ip nhrp output
| * | | | nhrpd: normalize sh ip nhrp opennhrp outputLouis Scalbert2024-10-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command outputs too much "\n". Normalize it. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
| * | | | nhrpd: fix sh ip nhrp opennhrp json counterLouis Scalbert2024-10-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "show ip nhrp opennhrp json" counter is incorrect. > root@nhs1:/# vtysh -c 'sh ip nhrp opennhrp json' | jq . > { > "attr": { > "status": "ok", > "entriesCount": 1 <=== NOK > }, > "table": [ > { > "type": "dynamic", > "up": true, > "used": false, > "protocolAddress": "172.16.1.4", > "protocolAddressSize": 32, > "nbmaAddress": "192.168.2.4" > }, > { > "type": "dynamic", > "up": true, > "used": false, > "protocolAddress": "172.16.1.5", > "protocolAddressSize": 32, > "nbmaAddress": "192.168.2.5" > } > ] > } > Fixes: 87b9e98203 ("nhrpd: add json support to show nhrp vty commands") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
* | | | | Merge pull request #17491 from pguibert6WIND/bgp_evpn_rt5_routemapDonatas Abraitis6 days5-66/+652
|\ \ \ \ \ | | | | | | | | | | | | Bgp evpn rt5 routemap
| * | | | | topotests: bgp_evpn_rt5, add test for advertise route-map servicePhilippe Guibert7 days3-2/+246
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the advertise route-map command, and check that it filters out correctly the undesirable prefixes. Reversely, check that undoing that route-map recovers all prefixes. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
| * | | | | topotests: bgp_evpn_rt5, rework testPhilippe Guibert7 days3-65/+407
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rework the test file by adding test methods. Add a convergence test that checks for the incoming BGP prefixes. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | | | | Merge pull request #17520 from mikemallin/dev/ubuntu-docker-custom-uidDonatas Abraitis6 days1-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Docker: Add the ability to override the FRR UID during docker creation
| * | | | | | Docker: Add the ability to override FRR UIDMike RE Mallin8 days1-1/+2
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Mike RE Mallin <mmallin@cisco.com> Signed-off-by: Mike RE Mallin <mremallin@gmail.com>
* | | | | | Merge pull request #15542 from pguibert6WIND/bgp_srv6_real_sidDonatas Abraitis6 days1-2/+9
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | bgpd: fix use real SID in BGP nexthop tracking
| * | | | | bgpd: fix use real SID in BGP nexthop trackingPhilippe Guibert6 days1-2/+9
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When receiving an SRv6 BGP update, the nexthop tracking is used to find out the reachability of the BGP update. > # show bgp ipv6 vpn fd00:200::/64 > Paths: (1 available, best #1) > [..] > 4:4::4:4 from 4:4::4:4 (4.4.4.4) > Origin incomplete, metric 0, localpref 100, valid, internal, best (First path received) > Extended Community: RT:52:100 > Remote label: 16 > Remote SID: 2001:db8:f4:: > Last update: Mon Mar 11 11:50:04 2024 The IPv6 address used is the "Remote SID". Actually, this value is incomplete. Remote SID stands for the attribute value received in BGP, while the label value determines a complement of SRv6 SID value. The transposition technique authorises that in BGP, and in the above case, the incoming BGP update has used the transposition length. When there is a transposition in the SID attribute available, use the real SID address. The nexthop tracking will use that forged address. > # show bgp nexthop > Current BGP nexthop cache: > 4:4::4:4 valid [IGP metric 30], #paths 0, peer 4:4::4:4 > gate fe80::dced:1ff:fed6:878c, if ntfp3 > Last update: Mon Mar 11 11:50:02 2024 > 2001:db8:f4:1:: valid [IGP metric 0], #paths 2 > gate fe80::dced:1ff:fed6:878c, if ntfp3 Fixes: 26c747ed6c0b ("bgpd: extend make_prefix to form srv6-based prefix") Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | | | Merge pull request #17527 from guoguojia2021/guozhongfeng_alibabaDonatas Abraitis7 days1-0/+1
|\ \ \ \ \ | |_|_|_|/ |/| | | | doc:Fix bgp doc warning
| * | | | doc:Fix bgp doc warningguozhongfeng.gzf8 days1-0/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: guozhongfeng.gzf <guozhongfeng.gzf@alibaba-inc.com>
* | | | | Merge pull request #17519 from chiragshah6/evpn_dev4Mark Stapp8 days2-5/+4
|\ \ \ \ \ | | | | | | | | | | | | zebra: EVPN fix code style in vlan vni map debugs
| * | | | | zebra: EVPN fix code style in vlan vni map debugsChirag Shah8 days2-5/+4
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix up couple of style issues missed in PR 17483 Signed-off-by: Chirag Shah <chirag@nvidia.com>
* | | | | Merge pull request #17385 from ↵Donatas Abraitis8 days9-225/+117
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | donaldsharp/more_found_connection_conversion_issues More found connection conversion issues
| * | | | | bgpd: peer_active is connection oriented, make it soDonald Sharp8 days6-21/+22
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | bgpd: bgp_getsockname should use connectionDonald Sharp8 days4-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's use the connection associated with the peer instead. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | bgpd: Modify bgp_connect_in_progress_update_connection to use connectionDonald Sharp8 days1-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 17:03:56 +0100