summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* *: remove VTYNL, part 1 of 6David Lamparter2017-07-1450-219/+219
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* ospf6d: VNL -> VTYNLDavid Lamparter2017-07-1415-345/+345
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: ditch vty_outln(), part 2 of 2David Lamparter2017-07-1437-233/+233
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: ditch vty_outln(), part 1 of 2David Lamparter2017-07-13119-2685/+2685
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib: move \n vs. \r\n handling into vty codeDavid Lamparter2017-07-135-44/+74
| | | | | | | | | | | | Instead of having an ?: expression embedded in every single caller of vty_out, just expand \n to \r\n in the vty code if neccessary. (Deprecation warnings will be enabled in the next commits which will do the search-and-replace over the codebase.) [This reverts commit 4d5f445 "lib: add vty_outln()"] Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib: vty: warn when using compatibility macrosDavid Lamparter2017-07-131-7/+29
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: COMMUNITY.md: compatibility foo & deprecationDavid Lamparter2017-07-131-0/+12
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* doc: add Backwards Compatibility section to COMMUNITY.mdLou Berger2017-07-111-0/+21
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* vty: add some more defines for backwards compatibilityLou Berger2017-07-111-0/+4
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* vty: add some defines for backwards compatibilityLou Berger2017-07-111-0/+5
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* bgpd: have labeled unicast print consistent with other safisLou Berger2017-07-111-2/+2
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* Merge branch 'evpn-prep'David Lamparter2017-07-1018-91/+394
|\ | | | | | | | | | | First 12-and-a-half commits from PR #619 Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * lib: Remove typedef from ipaddrDonald Sharp2017-07-102-6/+6
| | | | | | | | | | | | | | | | The ipaddr_t type was conflicting with code on omnios. Remove the typedef Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * Merge commit '3d22338f04d9554fa' into evpn-prepDavid Lamparter2017-07-1018-91/+394
| |\ | | | | | | | | | | | | | | | | | | Conflicts: lib/Makefile.am Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| | * bgpd: Fixes related to use of L2VPN/EVPNvivek2017-05-253-6/+10
| | | | | | | | | | | | | | | | | | | | | Add checks related to AFI_L2VPN/SAFI_EVPN that were missing in some parts of the code. Fix incorrect check skipping EVPN when sending End of RIB. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * bgpd: Fix route handling for 2-level routing tablesvivek2017-05-251-3/+28
| | | | | | | | | | | | | | | | | | | | | | | | For certain (sub) address families such as EVPN or L3VPN, the routing table is organized as a 2-level tree. Ensure that code walking the routing table does the correct handling in such cases. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * bgpd: Fix route detailed show for EVPNvivek2017-05-251-1/+2
| | | | | | | | | | | | Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * zebra: Format netlink requests correctlyvivek2017-05-254-26/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When zebra issues read (GET) requests to the kernel using the netlink interface, it is incorrect to format all of them in a generic manner using 'struct ifinfomsg' or 'struct rtgenmsg'. Rather, messages for a particular entity (e.g., routes) should use the corresponding structure for encoding (e.g., 'struct rtmsg'). Of course, this has to correlate with what the kernel expects. In the absence of this, there is the possibility of sending extraneous information in the request which the kernel wouldn't like. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: David Ahern <dsa@cumulusnetworks.com>
| | * zebra: Set nlmsg_pid in netlink_talk()vivek2017-05-251-0/+1
| | | | | | | | | | | | | | | | | | While it is not essential to set this, it seems a good thing to do. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * zebra: New API for filling netlink attributevivek2017-05-252-0/+8
| | | | | | | | | | | | | | | | | | Define addattr16(). Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * lib: Refine EVPN prefix definitionvivek2017-05-255-54/+99
| | | | | | | | | | | | | | | | | | | | | | | | | | | Modify EVPN prefix to use the generic IP address structure. Add support for EVPN type-2 and type-3 prefix dump. Fix references to modified fields as needed. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
| | * lib: Define generic IP address structurevivek2017-05-252-0/+95
| | | | | | | | | | | | | | | | | | | | | | | | Define an IP address structure which is a union of an IPv4 and IPv6 address. This is for subsequent use in EVPN. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
| | * lib: Additional APIs in bitfield libraryvivek2017-05-251-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added APIs to: a) pre-assign 0th bit in the bitfield b) free 0th bit in the bitfield c) free the allocated bitfield data Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com> Reviewed-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * lib: Macro for number of entries in hash tablevivek2017-05-251-0/+2
| | | | | | | | | | | | Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| | * lib: VxLAN Network Identifier definitionvivek2017-05-252-0/+30
| | | | | | | | | | | | | | | Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
| | * lib: VLAN definitionvivek2017-05-252-0/+30
| | | | | | | | | | | | | | | Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | | Merge pull request #786 from dwalton76/bgpd-peergroup-activateRuss White2017-07-101-0/+4
|\ \ \ | |/ / |/| | bgpd: peer-group members 'activate' when they shouldn't
| * | bgpd: peer-group members 'activate' when they shouldn'tDaniel Walton2017-07-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com> Today if you configure the following where the 'fabric' peer-group has been deactivated for ipv4 unicast and then assign swp1/swp2 to that peer-group we end up activating those two peers for ipv4 unicast. conf t no router bgp 100 router bgp 100 neighbor fabric peer-group neighbor fabric capability extended-nexthop neighbor fabric remote-as external ! address-family ipv4 unicast no neighbor fabric activate ! neighbor swp1 interface peer-group fabric neighbor swp2 interface peer-group fabric neighbor 1.1.1.1 peer-group fabric end cel-redxp-10# show run bgp ! router bgp 100 neighbor fabric peer-group neighbor fabric remote-as external neighbor fabric capability extended-nexthop neighbor swp1 interface peer-group fabric neighbor swp2 interface peer-group fabric neighbor 1.1.1.1 peer-group fabric ! address-family ipv4 unicast no neighbor fabric activate neighbor swp1 activate neighbor swp2 activate exit-address-family ! cel-redxp-10# With the patch we do not activate swp1/swp2 cel-redxp-10# show run bgp ! router bgp 100 neighbor fabric peer-group neighbor fabric remote-as external neighbor fabric capability extended-nexthop neighbor swp1 interface peer-group fabric neighbor swp2 interface peer-group fabric neighbor 1.1.1.1 peer-group fabric ! address-family ipv4 unicast no neighbor fabric activate exit-address-family ! cel-redxp-10#
* | | Merge pull request #733 from dwalton76/bgpd-ipv4-plus-label-misc3Russ White2017-07-1031-285/+343
|\ \ \ | | | | | | | | bgpd: Install SAFI_LABELED_UNICAST routes in SAFI_UNICAST table
| * | | bgpd: Install SAFI_LABELED_UNICAST routes in SAFI_UNICAST tableDaniel Walton2017-07-101-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
| * | | Merge branch 'master' of https://github.com/dwalton76/frr into ↵Daniel Walton2017-07-1025-361/+123
| |\ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | bgpd-ipv4-plus-label-misc3 Conflicts: bgpd/bgp_route.c bgpd/bgp_zebra.c
* | | | Merge pull request #750 from donaldsharp/bgp_bufferMartin Winter2017-07-073-187/+42
|\ \ \ \ | |_|/ / |/| | | Bgp buffer
| * | | bgpd: Refactor looping for talking to zebraDonald Sharp2017-06-221-93/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The data for each nexthop is stored off of the info pointer, instead of handling the first one and then looping over the remaining, just loop over them all and handle the first one as a special case. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * | | bgpd: Make buffer sizes automatically the correct sizeDonald Sharp2017-06-223-94/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the bgp code to send routes to zebra we were spending a non trivial amount of time managing buffer sizes. We know a priori the multipath supported by our system so let's just use that value to appropriately size the buffers. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | | | Merge pull request #778 from qlyoung/fix-excess-docstringRuss White2017-07-0717-156/+63
|\ \ \ \ | | | | | | | | | | Fix excess docstring
| * | | | lib: fix more docstringsQuentin Young2017-07-062-5/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | | | *: fix excess docstringQuentin Young2017-07-0514-151/+53
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | | | lib: warn about too much docstringQuentin Young2017-07-051-0/+8
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | | | Merge pull request #779 from qlyoung/update-docsMartin Winter2017-07-073-12/+12
|\ \ \ \ \ | | | | | | | | | | | | doc: update build docs for ubuntu
| * | | | | doc: update build docs for ubuntuQuentin Young2017-07-053-12/+12
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | cumulus/etc --> tools/etc Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | | | Merge pull request #777 from qlyoung/fix-mpls-str2labelDavid Lamparter2017-07-061-1/+1
|\ \ \ \ \ | | | | | | | | | | | | zebra: fix mpls_str2label()
| * | | | | zebra: fix mpls_str2label()Quentin Young2017-07-051-1/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When making improvements to error handling in this code I accidentally introduced an off-by-one. Fix it. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | | | Merge pull request #781 from opensourcerouting/vty-out-bufresizeQuentin Young2017-07-061-2/+4
|\ \ \ \ \ | | | | | | | | | | | | lib: fix vty_out with >1024 bytes of output
| * | | | | lib: fix vty_out with >1024 bytes of outputDavid Lamparter2017-07-061-2/+4
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consuming va_args modifies its internal bits, hence the need to copy it... but the copying wasn't quite right just yet. Fixes: 4d5f445 ("lib: add vty_outln()") Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | | | | Merge pull request #780 from dwalton76/bgpd-address-family-vty-outQuentin Young2017-07-051-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | bgpd: "address-family" not displayed in configuration
| * | | | bgpd: "address-family" not displayed in configurationDaniel Walton2017-07-051-1/+1
|/ / / / | | | | | | | | | | | | | | | | Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
| | * | bgpd: Install SAFI_LABELED_UNICAST routes in SAFI_UNICAST tableDaniel Walton2017-07-052-39/+4
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
| | * | Merge branch 'master' of https://github.com/dwalton76/frr into ↵Daniel Walton2017-07-0535-67/+328
| | |\ \ | |_|/ / |/| | | | | | | bgpd-ipv4-plus-label-misc3
* | | | Merge pull request #742 from qlyoung/hashstatsMartin Winter2017-07-0432-56/+314
|\ \ \ \ | | | | | | | | | | Hashtable statistics
| * | | | lib, vtysh: rebase hashstatsQuentin Young2017-07-022-17/+14
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>